Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: src/builtins/x64/builtins-x64.cc

Issue 2644643011: [builtins] Don't put doubles on the stack in ConstructWithSpread. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 2907 matching lines...) Expand 10 before | Expand all | Expand 10 after
2918 __ movp(rcx, FieldOperand(rcx, HeapObject::kMapOffset)); 2918 __ movp(rcx, FieldOperand(rcx, HeapObject::kMapOffset));
2919 __ cmpp(rcx, ContextOperand( 2919 __ cmpp(rcx, ContextOperand(
2920 r14, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX)); 2920 r14, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX));
2921 __ j(not_equal, &runtime_call); 2921 __ j(not_equal, &runtime_call);
2922 2922
2923 // For FastPacked kinds, iteration will have the same effect as simply 2923 // For FastPacked kinds, iteration will have the same effect as simply
2924 // accessing each property in order. 2924 // accessing each property in order.
2925 Label no_protector_check; 2925 Label no_protector_check;
2926 __ movzxbp(rcx, FieldOperand(r15, Map::kBitField2Offset)); 2926 __ movzxbp(rcx, FieldOperand(r15, Map::kBitField2Offset));
2927 __ DecodeField<Map::ElementsKindBits>(rcx); 2927 __ DecodeField<Map::ElementsKindBits>(rcx);
2928 __ cmpp(rcx, Immediate(LAST_FAST_ELEMENTS_KIND)); 2928 __ cmpp(rcx, Immediate(FAST_HOLEY_ELEMENTS));
2929 __ j(above, &runtime_call); 2929 __ j(above, &runtime_call);
2930 // For non-FastHoley kinds, we can skip the protector check. 2930 // For non-FastHoley kinds, we can skip the protector check.
2931 __ cmpp(rcx, Immediate(FAST_SMI_ELEMENTS)); 2931 __ cmpp(rcx, Immediate(FAST_SMI_ELEMENTS));
2932 __ j(equal, &no_protector_check); 2932 __ j(equal, &no_protector_check);
2933 __ cmpp(rcx, Immediate(FAST_ELEMENTS)); 2933 __ cmpp(rcx, Immediate(FAST_ELEMENTS));
2934 __ j(equal, &no_protector_check); 2934 __ j(equal, &no_protector_check);
2935 __ cmpp(rcx, Immediate(FAST_DOUBLE_ELEMENTS));
2936 __ j(equal, &no_protector_check);
2937 // Check the ArrayProtector cell. 2935 // Check the ArrayProtector cell.
2938 __ LoadRoot(rcx, Heap::kArrayProtectorRootIndex); 2936 __ LoadRoot(rcx, Heap::kArrayProtectorRootIndex);
2939 __ Cmp(FieldOperand(rcx, PropertyCell::kValueOffset), 2937 __ Cmp(FieldOperand(rcx, PropertyCell::kValueOffset),
2940 Smi::FromInt(Isolate::kProtectorValid)); 2938 Smi::FromInt(Isolate::kProtectorValid));
2941 __ j(not_equal, &runtime_call); 2939 __ j(not_equal, &runtime_call);
2942 2940
2943 __ bind(&no_protector_check); 2941 __ bind(&no_protector_check);
2944 // Load the FixedArray backing store. 2942 // Load the FixedArray backing store.
2945 __ movp(rbx, FieldOperand(rbx, JSArray::kElementsOffset)); 2943 __ movp(rbx, FieldOperand(rbx, JSArray::kElementsOffset));
2946 __ jmp(&push_args); 2944 __ jmp(&push_args);
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
3176 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) { 3174 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) {
3177 Generate_OnStackReplacementHelper(masm, true); 3175 Generate_OnStackReplacementHelper(masm, true);
3178 } 3176 }
3179 3177
3180 #undef __ 3178 #undef __
3181 3179
3182 } // namespace internal 3180 } // namespace internal
3183 } // namespace v8 3181 } // namespace v8
3184 3182
3185 #endif // V8_TARGET_ARCH_X64 3183 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698