Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2644233003: Revert of [debugger api] remove legacy JSON debug protocol. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger api] remove legacy JSON debug protocol. (patchset #2 id:20001 of https://codereview.chromium.org/2642253005/ ) Reason for revert: Node.js relies on this Original issue's description: > [debugger api] remove legacy JSON debug protocol. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2642253005 > Cr-Commit-Position: refs/heads/master@{#42543} > Committed: https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f4971a41f TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5530 Review-Url: https://codereview.chromium.org/2644233003 Cr-Commit-Position: refs/heads/master@{#42549} Committed: https://chromium.googlesource.com/v8/v8/+/7e420cf186c1422b07b2b8458ad98a53275658c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2669 lines, -44 lines) Patch
M include/v8-debug.h View 5 chunks +137 lines, -9 lines 0 comments Download
M src/api.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/debug/debug.h View 8 chunks +136 lines, -7 lines 0 comments Download
M src/debug/debug.cc View 18 chunks +419 lines, -22 lines 0 comments Download
M src/debug/debug.js View 6 chunks +1354 lines, -0 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +566 lines, -0 lines 0 comments Download
M src/execution.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yang
Created Revert of [debugger api] remove legacy JSON debug protocol.
3 years, 11 months ago (2017-01-20 11:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644233003/1
3 years, 11 months ago (2017-01-20 11:29:59 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 11:30:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7e420cf186c1422b07b2b8458ad98a53275...

Powered by Google App Engine
This is Rietveld 408576698