[debugger api] remove legacy JSON debug protocol.

[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2642253005
Cr-Original-Commit-Position: refs/heads/master@{#42543}
Committed: https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f4971a41f
Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42595}
Committed: https://chromium.googlesource.com/v8/v8/+/876da98a5182a03f631f9ab4469bd6838225cb16

[Yang, 2017-01-20 09:21:22]

Please take a look. This is in agreement with what we agreed for the legacy JSON
debug protocol.

[Yang, 2017-01-20 09:21:35]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 09:21:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 09:31:31]

Thanks, lgtm!

https://codereview.chromium.org/2642253005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2642253005/diff/1/src/debug/debug.cc#newcode1921
src/debug/debug.cc:1921: // a JavaScript function. Don't call event listener for
v8::Break
The last sentence seems no longer relevant.

[Yang, 2017-01-20 09:47:03]

addressed comments. will attempt to land.

[Yang, 2017-01-20 09:47:07]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-20 09:47:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2642253005/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-20 09:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 10:44:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484905627590920,
"parent_rev": "37cdb18bb7d5ce573e4ff4f6d48719e23e6a11b9", "commit_rev":
"e26a58e43c51a680a0a6363e0066886f4971a41f"}

[commit-bot: I haz the power, 2017-01-20 10:44:32]

Description was changed from

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530
==========

to

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42543}
Committed:
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...
==========

[commit-bot: I haz the power, 2017-01-20 10:44:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...

[Yang, 2017-01-20 11:29:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2644233003/ by yangguo@chromium.org.

The reason for reverting is: Node.js relies on this.

[Yang, 2017-01-20 13:00:41]

Description was changed from

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42543}
Committed:
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...
==========

to

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42543}
Committed:
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...
==========

[Yang, 2017-01-23 06:05:32]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-23 06:05:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2642253005/#ps40001
(title: "revert changes to the API")

[commit-bot: I haz the power, 2017-01-23 06:05:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 06:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 06:09:05]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33057)

[Yang, 2017-01-23 06:14:53]

Clemens, can you please review src/wasm? Thanks.

[Yang, 2017-01-23 09:22:00]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 09:22:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 09:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 09:56:33]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-23 10:41:56]

On 2017/01/23 at 06:14:53, yangguo wrote:
> Clemens, can you please review src/wasm? Thanks.

wasm lgtm.

[Yang, 2017-01-23 10:42:34]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-23 10:42:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2642253005/#ps60001
(title: "fix cctest")

[commit-bot: I haz the power, 2017-01-23 10:42:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 10:44:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485168154503630,
"parent_rev": "3a9152ece721903d3b82e60e8d95f51341183f28", "commit_rev":
"876da98a5182a03f631f9ab4469bd6838225cb16"}

[commit-bot: I haz the power, 2017-01-23 10:44:29]

Description was changed from

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42543}
Committed:
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...
==========

to

==========
[debugger api] remove legacy JSON debug protocol.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2642253005
Cr-Original-Commit-Position: refs/heads/master@{#42543}
Committed:
https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f497...
Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42595}
Committed:
https://chromium.googlesource.com/v8/v8/+/876da98a5182a03f631f9ab4469bd683822...
==========

[commit-bot: I haz the power, 2017-01-23 10:44:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/876da98a5182a03f631f9ab4469bd683822...