Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: logdog/appengine/coordinator/endpoints/services/getConfig_test.go

Issue 2643803003: config: Update remote URL handling. (Closed)
Patch Set: Fix "nost" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/appengine/coordinator/endpoints/services/getConfig.go ('k') | logdog/server/service/config/flag.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/appengine/coordinator/endpoints/services/getConfig_test.go
diff --git a/logdog/appengine/coordinator/endpoints/services/getConfig_test.go b/logdog/appengine/coordinator/endpoints/services/getConfig_test.go
index 618ade48b4b69157b83faf573700db1aea36e58d..3a4319548e945a630fb8f63658fe207857a5e5e8 100644
--- a/logdog/appengine/coordinator/endpoints/services/getConfig_test.go
+++ b/logdog/appengine/coordinator/endpoints/services/getConfig_test.go
@@ -10,6 +10,7 @@ import (
"github.com/luci/luci-go/logdog/api/config/svcconfig"
"github.com/luci/luci-go/logdog/api/endpoints/coordinator/services/v1"
ct "github.com/luci/luci-go/logdog/appengine/coordinator/coordinatorTest"
+ "github.com/luci/luci-go/luci_config/appengine/gaeconfig"
. "github.com/luci/luci-go/common/testing/assertions"
. "github.com/smartystreets/goconvey/convey"
@@ -21,6 +22,11 @@ func TestGetConfig(t *testing.T) {
Convey(`With a testing configuration`, t, func() {
c, env := ct.Install()
+ s := gaeconfig.Settings{
+ ConfigServiceHost: "example.com",
+ }
+ So(s.SetIfChanged(c, "test", "test"), ShouldBeNil)
+
svr := New()
Convey(`Returns Forbidden error if not a service.`, func() {
@@ -34,9 +40,10 @@ func TestGetConfig(t *testing.T) {
cr, err := svr.GetConfig(c, nil)
So(err, ShouldBeRPCOK)
So(cr, ShouldResemble, &logdog.GetConfigResponse{
- ConfigServiceUrl: "memory://",
+ ConfigServiceUrl: "test://example.com",
ConfigSet: "services/app",
ServiceConfigPath: svcconfig.ServiceConfigFilename,
+ ConfigServiceHost: "example.com",
})
})
})
« no previous file with comments | « logdog/appengine/coordinator/endpoints/services/getConfig.go ('k') | logdog/server/service/config/flag.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698