Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2642783008: Remove VoiceSearchProvider::CreateVoiceSearchBar(). (Closed)

Created:
3 years, 11 months ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VoiceSearchProvider::CreateVoiceSearchBar(). This functionality is now covered by BuildVoiceSearchBar(). BUG=679719 Review-Url: https://codereview.chromium.org/2642783008 Cr-Commit-Position: refs/heads/master@{#445825} Committed: https://chromium.googlesource.com/chromium/src/+/c2cdf6f411f8c5e8e7232fbf32b4b1eacea48268

Patch Set 1 #

Patch Set 2 : update BVC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 2 chunks +4 lines, -5 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
kkhorimoto
Third patch in 3-way patch.
3 years, 11 months ago (2017-01-19 23:05:32 UTC) #2
rohitrao (ping after 24h)
LGTM. You may also need to move the BVC changes into this CL.
3 years, 11 months ago (2017-01-20 14:01:05 UTC) #3
kkhorimoto
Moved BVC changes here
3 years, 11 months ago (2017-01-24 01:33:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642783008/20001
3 years, 11 months ago (2017-01-24 20:35:52 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 21:38:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2cdf6f411f8c5e8e7232fbf32b4...

Powered by Google App Engine
This is Rietveld 408576698