Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2642783008: Remove VoiceSearchProvider::CreateVoiceSearchBar(). (Closed)
Patch Set: update BVC Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/voice/voice_search_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index da9d2434e5333764648ae8be4ed2903a242da2bd..634095883a4a03c4939231743ababf1bbc6473f2 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -435,8 +435,7 @@ @interface BrowserViewController ()<AppRatingPromptDelegate,
std::unique_ptr<InfoBarContainerDelegateIOS> _infoBarContainerDelegate;
// Voice search bar at the bottom of the view overlayed on |_contentArea|
- // when displaying voice search results. Implementation is not complete.
- // See b/7998125.
+ // when displaying voice search results.
base::scoped_nsprotocol<UIView<VoiceSearchBar>*> _voiceSearchBar;
// The image fetcher used to save images and perform image-based searches.
@@ -2290,9 +2289,9 @@ - (void)ensureVoiceSearchBarCreated {
CGFloat width = CGRectGetWidth([[self view] bounds]);
CGFloat y = CGRectGetHeight([[self view] bounds]) - kVoiceSearchBarHeight;
CGRect frame = CGRectMake(0.0, y, width, kVoiceSearchBarHeight);
- _voiceSearchBar.reset(ios::GetChromeBrowserProvider()
- ->GetVoiceSearchProvider()
- ->CreateVoiceSearchBar(frame));
+ _voiceSearchBar.reset([ios::GetChromeBrowserProvider()
+ ->GetVoiceSearchProvider()
+ ->BuildVoiceSearchBar(frame) retain]);
[_voiceSearchBar setVoiceSearchBarDelegate:self];
[_voiceSearchBar setHidden:YES];
[_voiceSearchBar setAutoresizingMask:UIViewAutoresizingFlexibleTopMargin |
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/voice/voice_search_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698