ios/public/provider/chrome/browser/voice/voice_search_provider.h - Issue 2642783008: Remove VoiceSearchProvider::CreateVoiceSearchBar().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/provider/chrome/browser/voice/voice_search_provider.h

Issue 2642783008: Remove VoiceSearchProvider::CreateVoiceSearchBar(). (Closed)

Patch Set: update BVC Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/public/provider/chrome/browser/voice/voice_search_provider.h

diff --git a/ios/public/provider/chrome/browser/voice/voice_search_provider.h b/ios/public/provider/chrome/browser/voice/voice_search_provider.h

index 58f4ba6e867ee487f008b4f7d3913f361bbd0c92..0e7eeea11f7e66d1e5357f895647549f7475a437 100644

--- a/ios/public/provider/chrome/browser/voice/voice_search_provider.h

+++ b/ios/public/provider/chrome/browser/voice/voice_search_provider.h

@@ -40,12 +40,6 @@ class VoiceSearchProvider {

virtual scoped_refptr<VoiceSearchController> CreateVoiceSearchController(

ios::ChromeBrowserState* browser_state) const;

- // Creates a new VoiceSearchBar. The caller assumes ownership.

- // TODO(crbug.com/679719): Remove this once downstream provider implementaiton

- // switches to BuildVoiceSearchBar().

- virtual UIView<VoiceSearchBar>* CreateVoiceSearchBar(CGRect frame) const

- NS_RETURNS_RETAINED;

// Creates a new VoiceSearchBar. Returns an autoreleased view.

virtual UIView<VoiceSearchBar>* BuildVoiceSearchBar(CGRect frame) const;