Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2642763008: [Merge M56] arc: Restore UMA statistics for failures in LSO flow. (Closed)

Created:
3 years, 11 months ago by khmel
Modified:
3 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M56] arc: Restore UMA statistics for failures in LSO flow. This restores UMA reporting for failures in preparing HTTP contexts and also adds UMA reporting for auth failures in LSO to keep balanced with silent auth flow. Also fixes error when error page is not shown in case of GAIA server returns error. BUG=b/34111604 BUG=b/34108212 BUG=682389 BUG=682390 TEST=Manually on device. Simulated error case. Made sure that UMA is reported and expected error page is shown CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2618603003 Cr-Commit-Position: refs/heads/master@{#441792} (cherry picked from commit dc76842c78febcda874276d1d06971c7dbb99e9b) Review-Url: https://codereview.chromium.org/2642763008 Cr-Commit-Position: refs/branch-heads/2924@{#804} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/b04a3d75750e868b4854416fd0cd6f6771b87adc

Patch Set 1 #

Patch Set 2 : resolve conflicts #

Patch Set 3 : drop not required change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.h View 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/background.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642763008/40001
3 years, 11 months ago (2017-01-19 21:16:39 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 21:18:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b04a3d75750e868b4854416fd0cd...

Powered by Google App Engine
This is Rietveld 408576698