Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2642763008: [Merge M56] arc: Restore UMA statistics for failures in LSO flow. (Closed)
Patch Set: drop not required change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.h ('k') | chrome/browser/chromeos/arc/arc_support_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_auth_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc
index fae06a64a0ff0aa8750d41ee1a977b73c8faf138..dd19db7480c27fefb31cfb233d7512ce2bf2a567 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc
@@ -454,6 +454,7 @@ void ArcAuthService::OnContextPrepared(
if (request_context_getter) {
support_host_->ShowLso();
} else {
+ UpdateOptInCancelUMA(OptInCancelReason::NETWORK_ERROR);
support_host_->ShowError(ArcSupportHost::Error::SIGN_IN_NETWORK_ERROR,
false);
}
@@ -1111,6 +1112,12 @@ void ArcAuthService::OnAuthSucceeded(const std::string& auth_code) {
OnAuthCodeObtained(auth_code);
}
+void ArcAuthService::OnAuthFailed() {
+ // Don't report via callback. Extension is already showing more detailed
+ // information. Update only UMA here.
+ UpdateOptInCancelUMA(OptInCancelReason::NETWORK_ERROR);
+}
+
void ArcAuthService::OnRetryClicked() {
DCHECK(support_host_);
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.h ('k') | chrome/browser/chromeos/arc/arc_support_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698