arc: Restore UMA statistics for failures in LSO flow.

arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618603003
Cr-Commit-Position: refs/heads/master@{#441792}
Committed: https://chromium.googlesource.com/chromium/src/+/dc76842c78febcda874276d1d06971c7dbb99e9b

[khmel, 2017-01-05 21:20:07]

Description was changed from

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
==========

to

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[khmel, 2017-01-05 21:22:14]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2017-01-05 21:22:15]

Hi Xiyuan,

PTAL

PS: I will update BUG= field once b is up (currently down for Arc++ bugs)

[xiyuan, 2017-01-05 21:28:59]

lgtm

[khmel, 2017-01-05 22:04:49]

Thank you!

[khmel, 2017-01-05 22:04:53]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:05:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2017-01-05 23:03:36]

Description was changed from

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-06 01:31:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483653893395870, "parent_rev":
"27b95a92306e43c448f2f863c0bf10eae60fd625", "commit_rev":
"dc76842c78febcda874276d1d06971c7dbb99e9b"}

[commit-bot: I haz the power, 2017-01-06 01:31:36]

Description was changed from

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: Restore UMA statistics for failures in LSO flow.

This restores UMA reporting for failures in preparing HTTP contexts
and also adds UMA reporting for auth failures in LSO to keep balanced
with silent auth flow. Also fixes error when error page is not shown
in case of GAIA server returns error.

BUG=b/34111604
BUG=b/34108212
TEST=Manually on device. Simulated error case. Made sure that UMA
     is reported and expected error page is shown
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618603003
Cr-Commit-Position: refs/heads/master@{#441792}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc76842c78febcda874276d1d069...
==========

[commit-bot: I haz the power, 2017-01-06 01:31:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc76842c78febcda874276d1d069...