Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2642743006: Compile file_manager/common and volume_manager_wrapper in v2 syntax. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
oka1, fukino
CC:
chromium-reviews, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile file_manager/common and volume_manager_wrapper in v2 syntax. Also fixed indent and sort order of random gyp files. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2642743006 Cr-Commit-Position: refs/heads/master@{#444630} Committed: https://chromium.googlesource.com/chromium/src/+/adc103db18b8e88402f60b6c0979a55c7f6bc0d5

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add TODO. #

Patch Set 4 : Format. #

Messages

Total messages: 15 (8 generated)
oka
Rebase.
3 years, 11 months ago (2017-01-19 02:40:48 UTC) #2
oka
Add TODO.
3 years, 11 months ago (2017-01-19 02:58:50 UTC) #6
oka
Format.
3 years, 11 months ago (2017-01-19 03:03:37 UTC) #7
oka
PTAL.
3 years, 11 months ago (2017-01-19 03:03:52 UTC) #9
fukino
lgtm
3 years, 11 months ago (2017-01-19 03:18:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743006/60001
3 years, 11 months ago (2017-01-19 03:19:49 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 03:48:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/adc103db18b8e88402f60b6c0979...

Powered by Google App Engine
This is Rietveld 408576698