Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ui/file_manager/externs/background_window.js

Issue 2642743006: Compile file_manager/common and volume_manager_wrapper in v2 syntax. (Closed)
Patch Set: Format. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/externs/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/externs/background_window.js
diff --git a/ui/file_manager/externs/background_window.js b/ui/file_manager/externs/background_window.js
index e6e8322b79471ca937faf093abdae9c0c88bf319..b20bbf75b74fcf69ea6ae26b4933aa2f3974f4f6 100644
--- a/ui/file_manager/externs/background_window.js
+++ b/ui/file_manager/externs/background_window.js
@@ -21,8 +21,11 @@ BackgroundWindow.prototype.registerDialog = function(window) {};
/**
* @param {Object=} opt_appState App state.
* @param {number=} opt_id Window id.
- * @param {LaunchType=} opt_type Launch type. Default: ALWAYS_CREATE.
- * @param {function(string)=} opt_callback Completion callback with the App ID.
+ * TODO(oka): We intentionally omit optional launchType and callback parameters
+ * here because to do so we need to define |LaunchType| in this file, but then
+ * gyp v1 fails due to double definition of |LaunchType|. Since no foreground
+ * scripts set launchType parameter, we can omit them though it's hacky. Let's
+ * add them back after v1 is gone.
*/
BackgroundWindow.prototype.launchFileManager =
- function(opt_appState, opt_id, opt_type, opt_callback) {};
+ function(opt_appState, opt_id) {};
« no previous file with comments | « no previous file | ui/file_manager/externs/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698