Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2640243002: Compile most of file_manager/background scripts in v2. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile most of file_manager/background scripts in v2. ...except files contain circular deps and tests and mocks. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2640243002 Cr-Commit-Position: refs/heads/master@{#444658} Committed: https://chromium.googlesource.com/chromium/src/+/be6e22c406dd494b5ad0519a00b4805e892749fd

Patch Set 1 #

Patch Set 2 : sort. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -45 lines) Patch
M ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/file_manager/externs/progress_center_panel.js View 1 chunk +25 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources2.gyp View 1 4 chunks +115 lines, -45 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
oka
sort.
3 years, 11 months ago (2017-01-19 05:00:54 UTC) #2
oka
PTAL.
3 years, 11 months ago (2017-01-19 05:02:02 UTC) #4
fukino
lgtm
3 years, 11 months ago (2017-01-19 05:12:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640243002/20001
3 years, 11 months ago (2017-01-19 05:35:08 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 06:04:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be6e22c406dd494b5ad0519a00b4...

Powered by Google App Engine
This is Rietveld 408576698