Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2642743002: Revert [TypeFeedbackVector] Root literal arrays in function literal slots (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang, v8-mips-ports_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert [TypeFeedbackVector] Root literal arrays in function literal slots GC performance issues need to be addressed first. TBR=bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org BUG=v8:5456 Review-Url: https://codereview.chromium.org/2642743002 Cr-Original-Commit-Position: refs/heads/master@{#42495} Committed: https://chromium.googlesource.com/v8/v8/+/7803aa1ffb2f835c5f317ed2a097390d53e52567 Review-Url: https://codereview.chromium.org/2642743002 Cr-Commit-Position: refs/heads/master@{#42517} Committed: https://chromium.googlesource.com/v8/v8/+/55feaaea4c83bf72a409bb1ebde5b86c979d4d1c

Patch Set 1 #

Patch Set 2 : Disabled test. #

Patch Set 3 : Altered test for wasm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -352 lines) Patch
M src/builtins/arm/builtins-arm.cc View 5 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 2 5 chunks +15 lines, -8 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 2 4 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M src/compiler.cc View 1 2 4 chunks +19 lines, -12 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/contexts.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/contexts.cc View 6 chunks +27 lines, -8 lines 0 comments Download
M src/debug/liveedit.cc View 5 chunks +31 lines, -75 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 7 chunks +19 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 8 chunks +67 lines, -52 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +2 lines, -13 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +207 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +1 line, -3 lines 0 comments Download
D test/mjsunit/strong-rooted-literals.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 2645543002 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-18 13:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743002/1
3 years, 11 months ago (2017-01-18 13:41:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/15727) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-18 14:10:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743002/20001
3 years, 11 months ago (2017-01-19 10:02:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/7803aa1ffb2f835c5f317ed2a097390d53e52567
3 years, 11 months ago (2017-01-19 10:38:11 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2642933003/ by machenbach@chromium.org. ...
3 years, 11 months ago (2017-01-19 12:01:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642743002/40001
3 years, 11 months ago (2017-01-19 16:07:16 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 17:12:35 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/55feaaea4c83bf72a409bb1ebde5b86c979...

Powered by Google App Engine
This is Rietveld 408576698