Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2642933003: Revert of Revert [TypeFeedbackVector] Root literal arrays in function literal slots (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang, v8-mips-ports_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert [TypeFeedbackVector] Root literal arrays in function literal slots (patchset #2 id:20001 of https://codereview.chromium.org/2642743002/ ) Reason for revert: Breaks nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/13802 Original issue's description: > Revert [TypeFeedbackVector] Root literal arrays in function literal slots > > GC performance issues need to be addressed first. > > TBR=bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org > BUG=v8:5456 > > Review-Url: https://codereview.chromium.org/2642743002 > Cr-Commit-Position: refs/heads/master@{#42495} > Committed: https://chromium.googlesource.com/v8/v8/+/7803aa1ffb2f835c5f317ed2a097390d53e52567 TBR=mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5456 Review-Url: https://codereview.chromium.org/2642933003 Cr-Commit-Position: refs/heads/master@{#42496} Committed: https://chromium.googlesource.com/v8/v8/+/a8f289075758bdce5296ef517a269e1596b0ab99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -580 lines) Patch
M src/builtins/arm/builtins-arm.cc View 5 chunks +11 lines, -19 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 4 chunks +11 lines, -19 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 4 chunks +11 lines, -19 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +8 lines, -15 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M src/compiler.cc View 4 chunks +14 lines, -21 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/contexts.cc View 6 chunks +10 lines, -29 lines 0 comments Download
M src/debug/liveedit.cc View 5 chunks +77 lines, -33 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/objects.h View 7 chunks +6 lines, -19 lines 0 comments Download
M src/objects.cc View 8 chunks +54 lines, -69 lines 0 comments Download
M src/objects-inl.h View 2 chunks +14 lines, -3 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +3 lines, -207 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/strong-rooted-literals.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Revert [TypeFeedbackVector] Root literal arrays in function literal slots
3 years, 11 months ago (2017-01-19 12:01:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642933003/1
3 years, 11 months ago (2017-01-19 12:01:23 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 12:01:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a8f289075758bdce5296ef517a269e1596b...

Powered by Google App Engine
This is Rietveld 408576698