Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: test/cctest/test-feedback-vector.cc

Issue 2642743002: Revert [TypeFeedbackVector] Root literal arrays in function literal slots (Closed)
Patch Set: Altered test for wasm. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/mjsunit/strong-rooted-literals.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 #include "test/cctest/cctest.h" 6 #include "test/cctest/cctest.h"
7 7
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/execution.h" 10 #include "src/execution.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 FeedbackVectorSpec spec(&zone); 100 FeedbackVectorSpec spec(&zone);
101 spec.AddGeneralSlot(); 101 spec.AddGeneralSlot();
102 spec.AddCreateClosureSlot(5); 102 spec.AddCreateClosureSlot(5);
103 spec.AddGeneralSlot(); 103 spec.AddGeneralSlot();
104 vector = NewTypeFeedbackVector(isolate, &spec); 104 vector = NewTypeFeedbackVector(isolate, &spec);
105 FeedbackVectorHelper helper(vector); 105 FeedbackVectorHelper helper(vector);
106 CHECK_EQ(1, TypeFeedbackMetadata::GetSlotSize( 106 CHECK_EQ(1, TypeFeedbackMetadata::GetSlotSize(
107 FeedbackVectorSlotKind::CREATE_CLOSURE)); 107 FeedbackVectorSlotKind::CREATE_CLOSURE));
108 FeedbackVectorSlot slot = helper.slot(1); 108 FeedbackVectorSlot slot = helper.slot(1);
109 FixedArray* array = FixedArray::cast(vector->Get(slot)); 109 FixedArray* array = FixedArray::cast(vector->Get(slot));
110 CHECK_EQ(5, array->length()); 110 CHECK_EQ(array, *factory->empty_literals_array());
111 CHECK_EQ(5, vector->GetParameter(slot));
112 CHECK_EQ(array->get(0), *factory->undefined_value());
113 } 111 }
114 } 112 }
115 113
116 114
117 // IC slots need an encoding to recognize what is in there. 115 // IC slots need an encoding to recognize what is in there.
118 TEST(VectorICMetadata) { 116 TEST(VectorICMetadata) {
119 LocalContext context; 117 LocalContext context;
120 v8::HandleScope scope(context->GetIsolate()); 118 v8::HandleScope scope(context->GetIsolate());
121 Isolate* isolate = CcTest::i_isolate(); 119 Isolate* isolate = CcTest::i_isolate();
122 Zone zone(isolate->allocator(), ZONE_NAME); 120 Zone zone(isolate->allocator(), ZONE_NAME);
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 // There should be one IC slot. 597 // There should be one IC slot.
600 Handle<TypeFeedbackVector> feedback_vector(f->feedback_vector()); 598 Handle<TypeFeedbackVector> feedback_vector(f->feedback_vector());
601 FeedbackVectorHelper helper(feedback_vector); 599 FeedbackVectorHelper helper(feedback_vector);
602 CHECK_EQ(1, helper.slot_count()); 600 CHECK_EQ(1, helper.slot_count());
603 FeedbackVectorSlot slot(0); 601 FeedbackVectorSlot slot(0);
604 StoreICNexus nexus(feedback_vector, slot); 602 StoreICNexus nexus(feedback_vector, slot);
605 CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback()); 603 CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
606 } 604 }
607 605
608 } // namespace 606 } // namespace
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/mjsunit/strong-rooted-literals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698