Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2642663002: Rename class EditCommandComposition to UndoStep (Closed)

Created:
3 years, 11 months ago by Xiaocheng
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chongz, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename class EditCommandComposition to UndoStep This patch renames class EditCommandComposition to UndoStep to better match is usage. Follow up patches will clean up remaining names. BUG=682129 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2642663002 Cr-Commit-Position: refs/heads/master@{#444317} Committed: https://chromium.googlesource.com/chromium/src/+/5e5d50d1fe1c2322b6b2dc07681fd5804de80346

Patch Set 1 #

Patch Set 2 : Remove a redundant TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -59 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 1 2 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.cpp View 4 chunks +17 lines, -22 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
Xiaocheng
PTAL.
3 years, 11 months ago (2017-01-18 08:42:38 UTC) #6
yosin_UTC9
lgtm Excellent! You make my life easier!
3 years, 11 months ago (2017-01-18 08:52:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642663002/20001
3 years, 11 months ago (2017-01-18 09:40:08 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:45:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e5d50d1fe1c2322b6b2dc07681f...

Powered by Google App Engine
This is Rietveld 408576698