Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/core/editing/commands/UndoStep.h

Issue 2642663002: Rename class EditCommandComposition to UndoStep (Closed)
Patch Set: Remove a redundant TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/UndoStep.h
diff --git a/third_party/WebKit/Source/core/editing/commands/UndoStep.h b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
index 680a21eb36c9853dc487f4327e312a76e9109bd2..c0e1935eb3f2bc0a27e8b52c84dbd9b2c710ecde 100644
--- a/third_party/WebKit/Source/core/editing/commands/UndoStep.h
+++ b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
@@ -39,20 +39,18 @@ namespace blink {
class SimpleEditCommand;
-// TODO(xiaochengh): Rename this class to |UndoStep|.
-class EditCommandComposition
- : public GarbageCollectedFinalized<EditCommandComposition> {
+class UndoStep : public GarbageCollectedFinalized<UndoStep> {
public:
- static EditCommandComposition* create(Document*,
- const VisibleSelection&,
- const VisibleSelection&,
- InputEvent::InputType);
+ static UndoStep* create(Document*,
+ const VisibleSelection&,
+ const VisibleSelection&,
+ InputEvent::InputType);
void unapply();
void reapply();
InputEvent::InputType inputType() const;
void append(SimpleEditCommand*);
- void append(EditCommandComposition*);
+ void append(UndoStep*);
const VisibleSelection& startingSelection() const {
return m_startingSelection;
@@ -70,10 +68,10 @@ class EditCommandComposition
DECLARE_TRACE();
private:
- EditCommandComposition(Document*,
- const VisibleSelection& startingSelection,
- const VisibleSelection& endingSelection,
- InputEvent::InputType);
+ UndoStep(Document*,
+ const VisibleSelection& startingSelection,
+ const VisibleSelection& endingSelection,
+ InputEvent::InputType);
Member<Document> m_document;
VisibleSelection m_startingSelection;

Powered by Google App Engine
This is Rietveld 408576698