Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2642403002: Remove unnecessary third party dependencies (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary third party dependencies The CL https://codereview.chromium.org/11421224 added several third party dependencies required for the feature Chrome to Mobile. As the feature has been removed, this CL deals with removing the dependencies that the CL added. The action taken for each new dependency is listed below: - apache-mime4j: Removed from .gitignore and DEPS. - guava: Was deleted in https://codereview.chromium.org/602203003, but was later added back in https://codereview.chromium.org/2041583002. However, as its uses are now only related to tests, the 'testonly = true' flag has been added to its BUILD.gn file. - httpcomponents-client: Removed from .gitignore and DEPS. - httpcomponents-core: Removed from .gitignore and DEPS. - jarjar: Removed from .gitignore as https://codereview.chromium.org/2072873003 only deleted the DEPS entry. BUG=682983 Review-Url: https://codereview.chromium.org/2642403002 Cr-Commit-Position: refs/heads/master@{#445123} Committed: https://chromium.googlesource.com/chromium/src/+/b85b9eb8d1d91ccc172f53eec3e277eab60c47ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M .gitignore View 2 chunks +0 lines, -4 lines 0 comments Download
M DEPS View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/guava/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
nyquist
jbudorick: PTAL I don't know any more uses of these directories, and they're even all ...
3 years, 11 months ago (2017-01-20 17:52:47 UTC) #3
jbudorick
lgtm
3 years, 11 months ago (2017-01-20 17:57:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642403002/1
3 years, 11 months ago (2017-01-20 18:08:46 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:21:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b85b9eb8d1d91ccc172f53eec3e2...

Powered by Google App Engine
This is Rietveld 408576698