Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 602203003: Remove all things guava. (Closed)

Created:
6 years, 2 months ago by nyquist
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove all things guava. This removes the last files regarding guava since http://crbug.com/380688 has now been addressed. TBR=darin@chromium.org BUG=412673 Committed: https://crrev.com/f6b217d5def28636850ac9c02cbf56d4cd33fa72 Cr-Commit-Position: refs/heads/master@{#296796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -226 lines) Patch
D third_party/guava/COPYING View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/guava/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/guava/README.chromium View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nyquist
aurimas: PTAL
6 years, 2 months ago (2014-09-25 21:05:49 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 2 months ago (2014-09-25 21:07:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602203003/1
6 years, 2 months ago (2014-09-25 21:09:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13593)
6 years, 2 months ago (2014-09-25 21:21:08 UTC) #7
nyquist
darin: TBR removal of an unused directory.
6 years, 2 months ago (2014-09-25 21:25:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602203003/1
6 years, 2 months ago (2014-09-25 21:27:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5e61af0c0f560136104f707f5e976ea30342a5c7
6 years, 2 months ago (2014-09-25 21:32:33 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 21:34:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6b217d5def28636850ac9c02cbf56d4cd33fa72
Cr-Commit-Position: refs/heads/master@{#296796}

Powered by Google App Engine
This is Rietveld 408576698