Add guava to chromium third party

Add guava to chromium third party

BUG=2025423005
Committed: https://crrev.com/cbaf945853c92955a489aa08766e8bf90312f581
Cr-Commit-Position: refs/heads/master@{#401523}

[Yoland Yan(Google), 2016-06-03 23:15:08]

yolandyan@google.com changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2016-06-07 20:01:36]

Need this library for Robolectric 3.0

lgtm with comments.

https://codereview.chromium.org/2041583002/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2041583002/diff/40001/DEPS#newcode602
DEPS:602: 'src/build/android/update_third_party_jar.py',
Update script name

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/.giti...
File third_party/guava/.gitignore (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/.giti...
third_party/guava/.gitignore:1: *.jar
Probably, instead, add /third_party/guava/lib to src/.gitignore

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/READM...
File third_party/guava/README.chromium (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/READM...
third_party/guava/README.chromium:2: Shore Name: guava
s/Shore/Short

[mikecase (-- gone --), 2016-06-07 20:52:40]

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/BUILD.gn
File third_party/guava/BUILD.gn (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/BUILD...
third_party/guava/BUILD.gn:7: android_java_prebuilt("guava") {
As another sidenote. I know a lot of java targets are named like <name>_java
(so, guava_java). Don't know if there really is a naming convention to follow
though.

[Yoland Yan(Google), 2016-06-08 20:34:00]

https://codereview.chromium.org/2041583002/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2041583002/diff/40001/DEPS#newcode602
DEPS:602: 'src/build/android/update_third_party_jar.py',
On 2016/06/07 20:01:36, mikecase wrote:
> Update script name

Done.

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/.giti...
File third_party/guava/.gitignore (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/.giti...
third_party/guava/.gitignore:1: *.jar
On 2016/06/07 20:01:36, mikecase wrote:
> Probably, instead, add /third_party/guava/lib to src/.gitignore

Done.

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/BUILD.gn
File third_party/guava/BUILD.gn (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/BUILD...
third_party/guava/BUILD.gn:7: android_java_prebuilt("guava") {
On 2016/06/07 20:52:40, mikecase wrote:
> As another sidenote. I know a lot of java targets are named like <name>_java
> (so, guava_java). Don't know if there really is a naming convention to follow
> though.

Done. (also changed in other CLs)

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/READM...
File third_party/guava/README.chromium (right):

https://codereview.chromium.org/2041583002/diff/40001/third_party/guava/READM...
third_party/guava/README.chromium:2: Shore Name: guava
On 2016/06/07 20:01:36, mikecase wrote:
> s/Shore/Short

Done.

[Yoland Yan(Google), 2016-06-13 22:10:26]

yolandyan@google.com changed reviewers:
+ klobag@chromium.org

[Yoland Yan(Google), 2016-06-21 21:41:43]

https://codereview.chromium.org/2041583002/diff2/160001:180001/third_party/gu...

[klobag.chromium, 2016-06-21 21:49:02]

lgtm

[the real yoland, 2016-06-21 22:05:11]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2016-06-21 22:05:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2041583002/#ps180001
(title: "Add one-version policy notice in README.chromium")

[commit-bot: I haz the power, 2016-06-21 22:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041583002/180001

[commit-bot: I haz the power, 2016-06-22 00:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 00:40:59]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbudorick, 2016-06-22 15:58:19]

lgtm

[Yoland Yan(Google), 2016-06-23 01:23:31]

The CQ bit was checked by yolandyan@google.com

[Yoland Yan(Google), 2016-06-23 01:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org, jbudorick@chromium.org, klobag@chromium.org
Link to the patchset: https://codereview.chromium.org/2041583002/#ps200001
(title: "Rebase one last time")

[commit-bot: I haz the power, 2016-06-23 01:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041583002/200001

[commit-bot: I haz the power, 2016-06-23 02:35:00]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-23 02:36:56]

Description was changed from

==========
Add guava to chromium third party

BUG=2025423005
==========

to

==========
Add guava to chromium third party

BUG=2025423005

Committed: https://crrev.com/cbaf945853c92955a489aa08766e8bf90312f581
Cr-Commit-Position: refs/heads/master@{#401523}
==========

[commit-bot: I haz the power, 2016-06-23 02:36:57]

Patchset 11 (id:??) landed as
https://crrev.com/cbaf945853c92955a489aa08766e8bf90312f581
Cr-Commit-Position: refs/heads/master@{#401523}