Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs. The "purpose" attribute of
icons, if not set, defaults to IconPurpose::ANY.

BUG=649771
Review-Url: https://codereview.chromium.org/2642233002
Cr-Commit-Position: refs/heads/master@{#445554}
Committed: https://chromium.googlesource.com/chromium/src/+/4ca25bc262eece0c27b52eefec27ffb969359144

[F, 2017-01-19 22:46:59]

Description was changed from

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

BUG=649771
==========

to

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs.

BUG=649771
==========

[F, 2017-01-19 22:47:44]

zpeng@chromium.org changed reviewers:
+ dominickn@chromium.org

[F, 2017-01-19 22:47:44]

Hi Dominick, PTAL. Thanks!

[dominickn, 2017-01-19 23:29:21]

Please update installable_logging.cc:kManifestMissingSuitableIconMessage to
mention that 'the icon purpose property must include "any (or be left blank)"'

You can also mention in the CL description that icons which don't specify any
purpose have IconPurpose::ANY by default.

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
File chrome/browser/installable/installable_manager.cc (right):

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
chrome/browser/installable/installable_manager.cc:37: for (IconPurpose
icon_purpose : icon.purpose) {
return std::find(icon.purpose.begin(), icon.purpose.end(), purpose) !=
icon.purpose.end();

#include <algorithm> for std::find

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
chrome/browser/installable/installable_manager.cc:55: if (!HasIconPurpose(icon,
IconPurpose::ANY))
Nit: newline after continue

[F, 2017-01-20 00:28:59]

Description was changed from

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs.

BUG=649771
==========

to

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs. The "purpose" attribute of
icons, if not set, defaults to IconPurpose::ANY.

BUG=649771
==========

[F, 2017-01-20 00:36:01]

Thanks Dominick! PTAL

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
File chrome/browser/installable/installable_manager.cc (right):

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
chrome/browser/installable/installable_manager.cc:37: for (IconPurpose
icon_purpose : icon.purpose) {
On 2017/01/19 23:29:20, dominickn wrote:
> return std::find(icon.purpose.begin(), icon.purpose.end(), purpose) !=
> icon.purpose.end();
> 
> #include <algorithm> for std::find

Done.

https://codereview.chromium.org/2642233002/diff/1/chrome/browser/installable/...
chrome/browser/installable/installable_manager.cc:55: if (!HasIconPurpose(icon,
IconPurpose::ANY))
On 2017/01/19 23:29:20, dominickn wrote:
> Nit: newline after continue

Done.

[dominickn, 2017-01-20 00:37:21]

lgtm

[F, 2017-01-20 01:14:09]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-01-20 01:14:14]

The CQ bit was unchecked by zpeng@chromium.org

[F, 2017-01-20 22:02:44]

Patchset #3 (id:40001) has been deleted

[F, 2017-01-20 22:03:48]

Patchset #3 (id:60001) has been deleted

[F, 2017-01-23 23:22:04]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-01-23 23:22:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2642233002/#ps110001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-23 23:22:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:18:05]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1485213724680000,
"parent_rev": "6b01d4bae85592e3602311bd38532385a4c76fd8", "commit_rev":
"4ca25bc262eece0c27b52eefec27ffb969359144"}

[commit-bot: I haz the power, 2017-01-24 00:18:38]

Description was changed from

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs. The "purpose" attribute of
icons, if not set, defaults to IconPurpose::ANY.

BUG=649771
==========

to

==========
Require WebApp & WebAPK primary icons to have IconPurpose::ANY

Icons with only IconPurpose::BADGE as icon purposes should not be used
as primary icons for WebApps or WebAPKs. The "purpose" attribute of
icons, if not set, defaults to IconPurpose::ANY.

BUG=649771

Review-Url: https://codereview.chromium.org/2642233002
Cr-Commit-Position: refs/heads/master@{#445554}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ca25bc262eece0c27b52eefec27...
==========

[commit-bot: I haz the power, 2017-01-24 00:18:39]

Committed patchset #5 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/4ca25bc262eece0c27b52eefec27...