Require WebApp & WebAPK primary icons to have IconPurpose::ANY

chrome/browser/installable/installable_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/installable/installable_manager.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebDisplayMode.h"
 
+using IconPurpose = content::Manifest::Icon::IconPurpose;
+
 class InstallableManagerUnitTest : public testing::Test {
  public:
   InstallableManagerUnitTest() : manager_(new InstallableManager(nullptr)) { }
 
  protected:
   static base::NullableString16 ToNullableUTF16(const std::string& str) {
     return base::NullableString16(base::UTF8ToUTF16(str), false);
   }
 
   static content::Manifest GetValidManifest() {
     content::Manifest manifest;
     manifest.name = ToNullableUTF16("foo");
     manifest.short_name = ToNullableUTF16("bar");
     manifest.start_url = GURL("http://example.com");
     manifest.display = blink::WebDisplayModeStandalone;
 
     content::Manifest::Icon icon;
     icon.type = base::ASCIIToUTF16("image/png");
     icon.sizes.push_back(gfx::Size(144, 144));
+    icon.purpose.push_back(IconPurpose::ANY);
     manifest.icons.push_back(icon);
 
     return manifest;
   }
 
   bool IsManifestValid(const content::Manifest& manifest) {
     // Explicitly reset the error code before running the method.
     manager_->set_installable_error(NO_ERROR_DETECTED);
     return manager_->IsManifestValidForWebApp(manifest);
   }
@@ skipping 84 matching lines @@
   manifest.icons[0].src = GURL("http://example.com/icon.PNG");
   EXPECT_TRUE(IsManifestValid(manifest));
   EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
 
   // Non-png extensions are rejected.
   manifest.icons[0].src = GURL("http://example.com/icon.gif");
   EXPECT_FALSE(IsManifestValid(manifest));
   EXPECT_EQ(MANIFEST_MISSING_SUITABLE_ICON, GetErrorCode());
 }
 
+TEST_F(InstallableManagerUnitTest, ManifestRequiresPurposeAny) {
+  content::Manifest manifest = GetValidManifest();
+
+  // The icon MUST have IconPurpose::ANY at least.
+  manifest.icons[0].purpose[0] = IconPurpose::BADGE;
+  EXPECT_FALSE(IsManifestValid(manifest));
+  EXPECT_EQ(MANIFEST_MISSING_SUITABLE_ICON, GetErrorCode());
+
+  // If one of the icon purposes match the requirement, it should be accepted.
+  manifest.icons[0].purpose.push_back(IconPurpose::ANY);
+  EXPECT_TRUE(IsManifestValid(manifest));
+  EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
+}
+
 TEST_F(InstallableManagerUnitTest, ManifestRequiresMinimalSize) {
   content::Manifest manifest = GetValidManifest();
 
   // The icon MUST be 144x144 size at least.
   manifest.icons[0].sizes[0] = gfx::Size(1, 1);
   EXPECT_FALSE(IsManifestValid(manifest));
   EXPECT_EQ(MANIFEST_MISSING_SUITABLE_ICON, GetErrorCode());
 
   manifest.icons[0].sizes[0] = gfx::Size(143, 143);
   EXPECT_FALSE(IsManifestValid(manifest));
@@ skipping 36 matching lines @@
   EXPECT_EQ(MANIFEST_DISPLAY_NOT_SUPPORTED, GetErrorCode());
 
   manifest.display = blink::WebDisplayModeStandalone;
   EXPECT_TRUE(IsManifestValid(manifest));
   EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
 
   manifest.display = blink::WebDisplayModeFullscreen;
   EXPECT_TRUE(IsManifestValid(manifest));
   EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
 }