Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644623004:
Include Manifest.icons.purpose in manifest IPC message (Closed)
DescriptionInclude Manifest.icons.purpose in manifest IPC message
BUG=649771
Review-Url: https://codereview.chromium.org/2644623004
Cr-Commit-Position: refs/heads/master@{#445518}
Committed: https://chromium.googlesource.com/chromium/src/+/4632fefa03f6c48b3a038c1f2bea7f27b82ca2a3
Patch Set 1 : format #Patch Set 2 : rebase #
Dependent Patchsets: Messages
Total messages: 25 (15 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by zpeng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
zpeng@chromium.org changed reviewers: + pfeldman@chromium.org, rsesek@chromium.org
Hi Pavel & Robert, PTAL. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== Include Manifest.icons.purpose in manifest IPC message BUG=649771 ========== to ========== Include Manifest.icons.purpose in manifest IPC message BUG=649771 ==========
Hi Pavel, PTAL. Thanks!
lgtm
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for content/common/manifest_manager_messages.h: While running git apply --index -p1; error: patch failed: content/common/manifest_manager_messages.h:14 error: content/common/manifest_manager_messages.h: patch does not apply Patch: content/common/manifest_manager_messages.h Index: content/common/manifest_manager_messages.h diff --git a/content/common/manifest_manager_messages.h b/content/common/manifest_manager_messages.h index ae4a2d2a632b155705cae748656049b2fecea9f6..ef2f198c9a75329b55a7c838d652c647f952224d 100644 --- a/content/common/manifest_manager_messages.h +++ b/content/common/manifest_manager_messages.h @@ -14,10 +14,15 @@ #define IPC_MESSAGE_START ManifestManagerMsgStart +IPC_ENUM_TRAITS_MAX_VALUE( + content::Manifest::Icon::IconPurpose, + content::Manifest::Icon::IconPurpose::ICON_PURPOSE_LAST) + IPC_STRUCT_TRAITS_BEGIN(content::Manifest::Icon) IPC_STRUCT_TRAITS_MEMBER(src) IPC_STRUCT_TRAITS_MEMBER(type) IPC_STRUCT_TRAITS_MEMBER(sizes) + IPC_STRUCT_TRAITS_MEMBER(purpose) IPC_STRUCT_TRAITS_END() IPC_STRUCT_TRAITS_BEGIN(content::Manifest::RelatedApplication)
The CQ bit was checked by zpeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2644623004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by zpeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485203820197690,
"parent_rev": "757919eacf29328fb7e31e95a6833fa989fb1fac", "commit_rev":
"4632fefa03f6c48b3a038c1f2bea7f27b82ca2a3"}
Message was sent while issue was closed.
Description was changed from ========== Include Manifest.icons.purpose in manifest IPC message BUG=649771 ========== to ========== Include Manifest.icons.purpose in manifest IPC message BUG=649771 Review-Url: https://codereview.chromium.org/2644623004 Cr-Commit-Position: refs/heads/master@{#445518} Committed: https://chromium.googlesource.com/chromium/src/+/4632fefa03f6c48b3a038c1f2bea... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4632fefa03f6c48b3a038c1f2bea... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
