Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2641893002: Reland of Enable HttpFormWarning in fieldtrial_testing_config.json (Closed)

Created:
3 years, 11 months ago by estark
Modified:
3 years, 11 months ago
Reviewers:
jwd, pkalinnikov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2634093003/ ) Reason for revert: This seemed to trigger a previously existing test issue, which I fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=681710&desc=2#c14. I'll keep an eye on the flakiness dashboard after relanding this to make sure it's fixed. Original issue's description: > Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2629663002/ ) > > Reason for revert: > Likely causing flakiness of PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on Mac10.11/Mac10.10/Mac10.9 Tests. > > Original issue's description: > > Enable HttpFormWarning in fieldtrial_testing_config.json > > > > BUG=674320 > > > > Review-Url: https://codereview.chromium.org/2629663002 > > Cr-Commit-Position: refs/heads/master@{#443946} > > Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c > > TBR=jwd@chromium.org,estark@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=674320, 681710 > > Review-Url: https://codereview.chromium.org/2634093003 > Cr-Commit-Position: refs/heads/master@{#444036} > Committed: https://chromium.googlesource.com/chromium/src/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d TBR=jwd@chromium.org,pkalinnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=674320, 681710 Review-Url: https://codereview.chromium.org/2641893002 Cr-Commit-Position: refs/heads/master@{#444404} Committed: https://chromium.googlesource.com/chromium/src/+/c890ad04b852fcc9834b988cf896534228144bb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
estark
Created Reland of Enable HttpFormWarning in fieldtrial_testing_config.json
3 years, 11 months ago (2017-01-18 16:25:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641893002/1
3 years, 11 months ago (2017-01-18 16:25:31 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 17:10:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c890ad04b852fcc9834b988cf896...

Powered by Google App Engine
This is Rietveld 408576698