Chromium Code Reviews
DescriptionReland of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2634093003/ )
Reason for revert:
This seemed to trigger a previously existing test issue, which I fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=681710&desc=2#c14. I'll keep an eye on the flakiness dashboard after relanding this to make sure it's fixed.
Original issue's description:
> Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2629663002/ )
>
> Reason for revert:
> Likely causing flakiness of PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on Mac10.11/Mac10.10/Mac10.9 Tests.
>
> Original issue's description:
> > Enable HttpFormWarning in fieldtrial_testing_config.json
> >
> > BUG=674320
> >
> > Review-Url: https://codereview.chromium.org/2629663002
> > Cr-Commit-Position: refs/heads/master@{#443946}
> > Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c
>
> TBR=jwd@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=674320, 681710
>
> Review-Url: https://codereview.chromium.org/2634093003
> Cr-Commit-Position: refs/heads/master@{#444036}
> Committed: https://chromium.googlesource.com/chromium/src/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d
TBR=jwd@chromium.org,pkalinnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=674320, 681710
Review-Url: https://codereview.chromium.org/2641893002
Cr-Commit-Position: refs/heads/master@{#444404}
Committed: https://chromium.googlesource.com/chromium/src/+/c890ad04b852fcc9834b988cf896534228144bb4
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||