Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2634093003: Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (Closed)

Created:
3 years, 11 months ago by pkalinnikov
Modified:
3 years, 11 months ago
Reviewers:
jwd, estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2629663002/ ) Reason for revert: Likely causing flakiness of PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on Mac10.11/Mac10.10/Mac10.9 Tests. Original issue's description: > Enable HttpFormWarning in fieldtrial_testing_config.json > > BUG=674320 > > Review-Url: https://codereview.chromium.org/2629663002 > Cr-Commit-Position: refs/heads/master@{#443946} > Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c TBR=jwd@chromium.org,estark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=674320, 681710 Review-Url: https://codereview.chromium.org/2634093003 Cr-Commit-Position: refs/heads/master@{#444036} Committed: https://chromium.googlesource.com/chromium/src/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pkalinnikov
Created Revert of Enable HttpFormWarning in fieldtrial_testing_config.json
3 years, 11 months ago (2017-01-17 13:03:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634093003/1
3 years, 11 months ago (2017-01-17 13:04:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d
3 years, 11 months ago (2017-01-17 13:05:48 UTC) #7
estark
3 years, 11 months ago (2017-01-18 16:25:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2641893002/ by estark@chromium.org.

The reason for reverting is: This seemed to trigger a previously existing test
issue, which I fixed in
https://bugs.chromium.org/p/chromium/issues/detail?id=681710&desc=2#c14. I'll
keep an eye on the flakiness dashboard after relanding this to make sure it's
fixed..

Powered by Google App Engine
This is Rietveld 408576698