Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2629663002: Enable HttpFormWarning in fieldtrial_testing_config.json (Closed)

Created:
3 years, 11 months ago by estark
Modified:
3 years, 11 months ago
Reviewers:
jwd
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HttpFormWarning in fieldtrial_testing_config.json BUG=674320 Review-Url: https://codereview.chromium.org/2629663002 Cr-Commit-Position: refs/heads/master@{#443946} Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
estark
jwd, PTAL? Thanks!
3 years, 11 months ago (2017-01-12 19:43:04 UTC) #4
jwd
lgtm
3 years, 11 months ago (2017-01-16 20:11:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629663002/1
3 years, 11 months ago (2017-01-16 20:14:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c
3 years, 11 months ago (2017-01-16 21:37:23 UTC) #12
pkalinnikov
3 years, 11 months ago (2017-01-17 13:03:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2634093003/ by pkalinnikov@chromium.org.

The reason for reverting is: Likely causing flakiness of
PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on
Mac10.11/Mac10.10/Mac10.9 Tests..

Powered by Google App Engine
This is Rietveld 408576698