[refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo…

[refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebContents.

The implementation logic for both of the methods is inside WebContentsImpl.
It only makes sense to remove the methods to WebContents and also get rid
of the helper methods in RenderViewHostDelegate.

BUG=675975
Review-Url: https://codereview.chromium.org/2641403002
Cr-Commit-Position: refs/heads/master@{#445910}
Committed: https://chromium.googlesource.com/chromium/src/+/5c1f939d7ba5a1c17f045d6b622909902743454c

[EhsanK, 2017-01-20 19:47:36]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:48:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2017-01-20 19:50:49]

ekaramad@chromium.org changed reviewers:
+ nick@chromium.org

[EhsanK, 2017-01-20 19:50:49]

Nick, could you please take a look?

We should also try to refactor the NotificationObserver part into a
WebContentsObserver method (as you suggested in the previous CL). But this will
not be a simple refactoring because specifically AccessibilityHighlightManager
is a singleton class and we have to come up with a mechanism (perhaps a static
list of WebContentsObserver(s)) to handle this task. I left that for another CL.
This CL is a pure refactoring CL.

Thanks!

[commit-bot: I haz the power, 2017-01-20 21:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:28:30]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2017-01-24 18:08:45]

lgtm!

[EhsanK, 2017-01-24 19:22:09]

ekaramad@chromium.org changed reviewers:
+ sky@chromium.org

[EhsanK, 2017-01-24 19:22:10]

Thanks Nick!

sky@: Could you please take a look?

[sky, 2017-01-24 22:08:07]

LGTM

https://codereview.chromium.org/2641403002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2641403002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:1215: if
(web_contents->IsFocusedElementEditable())
Now that there is no temporary combine the if statements.

[EhsanK, 2017-01-25 01:00:38]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2017-01-25 01:01:39]

Patchset #3 (id:40001) has been deleted

[EhsanK, 2017-01-25 01:05:37]

Thanks for the reviews! I will CQ now.

https://codereview.chromium.org/2641403002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2641403002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:1215: if
(web_contents->IsFocusedElementEditable())
On 2017/01/24 22:08:06, sky wrote:
> Now that there is no temporary combine the if statements.

Done. Thanks!

[EhsanK, 2017-01-25 01:05:44]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2017-01-25 01:05:44]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2641403002/#ps60001
(title: "Addressed sky@'s comment")

[commit-bot: I haz the power, 2017-01-25 01:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 02:05:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485306344244440,
"parent_rev": "1b94b8d69f748e9c8e686220c26bb87c1a461602", "commit_rev":
"5c1f939d7ba5a1c17f045d6b622909902743454c"}

[commit-bot: I haz the power, 2017-01-25 02:06:37]

Description was changed from

==========
[refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from
RenderViewHost to WebContents.

The implementation logic for both of the methods is inside WebContentsImpl.
It only makes sense to remove the methods to WebContents and also get rid
of the helper methods in RenderViewHostDelegate.

BUG=675975
==========

to

==========
[refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from
RenderViewHost to WebContents.

The implementation logic for both of the methods is inside WebContentsImpl.
It only makes sense to remove the methods to WebContents and also get rid
of the helper methods in RenderViewHostDelegate.

BUG=675975

Review-Url: https://codereview.chromium.org/2641403002
Cr-Commit-Position: refs/heads/master@{#445910}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c1f939d7ba5a1c17f045d6b6229...
==========

[commit-bot: I haz the power, 2017-01-25 02:06:38]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5c1f939d7ba5a1c17f045d6b6229...