chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc - Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo… (Closed)

Patch Set: Addressed sky@'s comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

index b625633bc86d81ee933f72a63c71017cc7b923e5..27543b4e2af1d075ea2066b1c7d8963483d8bd2a 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

@@ -30,7 +30,7 @@ LocationBarBubbleDelegateView::WebContentMouseHandler::

void LocationBarBubbleDelegateView::WebContentMouseHandler::OnKeyEvent(

ui::KeyEvent* event) {

if ((event->key_code() == ui::VKEY_ESCAPE ||

- web_contents_->GetRenderViewHost()->IsFocusedElementEditable()) &&

+ web_contents_->IsFocusedElementEditable()) &&

event->type() == ui::ET_KEY_PRESSED)

bubble_->CloseBubble();

}