chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc - Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

Issue 2641403002: [refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebCo… (Closed)

Patch Set: Addressed sky@'s comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc ('k') | content/browser/renderer_host/render_view_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

index c37cf06c984b1af66ce5992c8f4b5fb4acc8b534..5bb18d38c7c9089f01e7d7b43d41b0f7c8912652 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

@@ -259,7 +259,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, CloseOnKey) {

EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_TAB_CONTAINER));

content::WebContents* web_contents =

browser()->tab_strip_model()->GetActiveWebContents();

- EXPECT_TRUE(web_contents->GetRenderViewHost()->IsFocusedElementEditable());

+ EXPECT_TRUE(web_contents->IsFocusedElementEditable());

ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_K,

false, false, false, false));

EXPECT_FALSE(IsBubbleShowing());