Issue 2641173008: [SPv2] Add CSS mask support

trchen

Description was changed from ========== [SPv2] Add CSS mask support WIP. What's done: * Build ...

3 years, 11 months ago (2017-01-21 01:01:01 UTC) #1

trchen

trchen@chromium.org changed reviewers: + chrishtr@chromium.org, pdr@chromium.org

3 years, 11 months ago (2017-01-21 01:02:42 UTC) #2

trchen

https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode2677 third_party/WebKit/Source/core/paint/PaintLayer.cpp:2677: bool PaintLayer::hasCompositedMask() const { Is it obvious to you ...

3 years, 11 months ago (2017-01-21 01:27:08 UTC) #4

chrishtr

Looking great! Needs unittests also. :) https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode2677 third_party/WebKit/Source/core/paint/PaintLayer.cpp:2677: bool PaintLayer::hasCompositedMask() const ...

3 years, 11 months ago (2017-01-24 01:16:28 UTC) #5

trchen

Description was changed from ========== [SPv2] Add CSS mask support WIP. What's done: * Build ...

3 years, 10 months ago (2017-02-11 02:34:49 UTC) #6

trchen

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-11 02:35:06 UTC) #7

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/60001

3 years, 10 months ago (2017-02-11 02:35:26 UTC) #8

trchen

Now ready for review. PTAL, thanks! https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2641173008/diff/1/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode2677 third_party/WebKit/Source/core/paint/PaintLayer.cpp:2677: bool PaintLayer::hasCompositedMask() const ...

3 years, 10 months ago (2017-02-11 02:35:45 UTC) #9

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-11 03:19:52 UTC) #10

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/307990) chromeos_daisy_chromium_compile_only_ng on ...

3 years, 10 months ago (2017-02-11 03:19:53 UTC) #11

chrishtr

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right): https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h#newcode94 third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:94: // The hierarchy of the effect subtree created by ...

3 years, 10 months ago (2017-02-11 23:55:11 UTC) #12

trchen

The unittest failure is probably due to font differences. I'll change font to Ahem and ...

3 years, 10 months ago (2017-02-13 21:12:02 UTC) #13

The unittest failure is probably due to font differences. I'll change font to
Ahem and try again.

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:94: // The
hierarchy of the effect subtree created by a LayoutObject as follows:
On 2017/02/11 23:55:11, chrishtr wrote:
> Nit: "...is as follows"

Done.

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2654: bool
PaintLayer::maskBlendingAppliedByCompositor() const {
On 2017/02/11 23:55:11, chrishtr wrote:
> In SPv2 mode, it's not really "applied by compositor", but
> insted applied by the property node, which may or may not
> end up surviving squashing in PaintArtifactCompositor.
> Maybe just add a TODO to rename this after launching?

The property tree is the representation of the effect and will be ultimately
applied by PaintArtifactCompositor/cc. IMO it isn't confusing if we consider PAC
a part of the compositor?

Anyway, I don't even think this should be a PaintLayer method. This information
really belongs to paintInfo.flags. We shouldn't lose sleep over its naming. :D

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:418: static
bool computeMaskParameters(IntRect& maskClip,
On 2017/02/11 23:55:11, chrishtr wrote:
> The bounds of the mask requires the bounds of children...this is a problem.
> It requires computing the bounding box of all descendants in general right?
> Which requires PaintLayerClipper?

Only for SVG. For HTML/CSS we only use the current element's border box [#1].
For SVG case I haven't figured out what the the spec means exactly. Following
the spec in verbatim would need PaintLayerClipper. I think we'll end up
mimicking whatever SPv1 did. 

[#1] Unless we're going to implement mask-clip:no-clip. In that case we can just
inherit context.inputClipOfCurrentEffect without creating a mask clip.

chrishtr

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode2654 third_party/WebKit/Source/core/paint/PaintLayer.cpp:2654: bool PaintLayer::maskBlendingAppliedByCompositor() const { On 2017/02/13 at 21:12:02, trchen ...

3 years, 10 months ago (2017-02-13 23:23:49 UTC) #14

trchen

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right): https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp#newcode425 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:425: // TODO(trchen): Figure out what to do with SVG. ...

3 years, 10 months ago (2017-02-14 01:37:30 UTC) #15

trchen

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-14 01:37:35 UTC) #16

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/80001

3 years, 10 months ago (2017-02-14 01:38:06 UTC) #17

chrishtr

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right): https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp#newcode445 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:445: maximumMaskRegion = toLayoutInline(object).linesBoundingBox(); On 2017/02/14 at 01:37:30, trchen wrote: ...

3 years, 10 months ago (2017-02-14 02:11:33 UTC) #18

trchen

https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right): https://codereview.chromium.org/2641173008/diff/60001/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp#newcode445 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:445: maximumMaskRegion = toLayoutInline(object).linesBoundingBox(); On 2017/02/14 02:11:33, chrishtr wrote: > ...

3 years, 10 months ago (2017-02-14 02:22:04 UTC) #19

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-14 02:53:37 UTC) #21

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/348101)

3 years, 10 months ago (2017-02-14 02:53:38 UTC) #22

trchen

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-15 01:04:21 UTC) #23

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/100001

3 years, 10 months ago (2017-02-15 01:05:50 UTC) #24

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-15 03:08:40 UTC) #25

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

3 years, 10 months ago (2017-02-15 03:08:41 UTC) #26

trchen

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-16 00:35:11 UTC) #27

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/120001

3 years, 10 months ago (2017-02-16 00:36:43 UTC) #28

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-16 02:41:03 UTC) #29

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ...

3 years, 10 months ago (2017-02-16 02:41:04 UTC) #30

trchen

The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the ...

3 years, 10 months ago (2017-02-16 20:06:19 UTC) #32

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/120001

3 years, 10 months ago (2017-02-16 20:07:03 UTC) #33

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-16 22:36:56 UTC) #34

commit-bot: I haz the power

Failed to apply patch for third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp: While running git apply --index -p1; error: patch failed: ...

3 years, 10 months ago (2017-02-16 22:36:58 UTC) #35

Failed to apply patch for
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:946
  error: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:
patch does not apply

Patch:       third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index
34b7942e959e2e6c6f757736832a8ca09f7c4a95..49620e1c14c34aa4b832c4253c1cb3e28f8dc0ec
100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -415,6 +415,38 @@ void PaintPropertyTreeBuilder::updateTransform(
   }
 }
 
+static bool computeMaskParameters(IntRect& maskClip,
+                                  const LayoutObject& object,
+                                  const LayoutPoint& paintOffset) {
+  DCHECK(object.isBoxModelObject() || object.isSVGChild());
+  const ComputedStyle& style = object.styleRef();
+
+  if (object.isSVGChild()) {
+    // TODO(trchen): Implement SVG masks.
+    return false;
+  }
+  if (!style.hasMask())
+    return false;
+
+  LayoutRect maximumMaskRegion;
+  // For HTML/CSS objects, the extent of the mask is known as "mask
+  // painting area", which is determined by CSS mask-clip property.
+  // We don't implement mask-clip:margin-box or no-clip currently,
+  // so the maximum we can get is border-box.
+  if (object.isBox()) {
+    maximumMaskRegion = toLayoutBox(object).borderBoxRect();
+  } else {
+    // For inline elements, depends on the value of box-decoration-break
+    // there could be one box in multiple fragments or multiple boxes.
+    // Either way here we are only interested in the bounding box of them.
+    DCHECK(object.isLayoutInline());
+    maximumMaskRegion = toLayoutInline(object).linesBoundingBox();
+  }
+  maximumMaskRegion.moveBy(paintOffset);
+  maskClip = enclosingIntRect(maximumMaskRegion);
+  return true;
+}
+
 void PaintPropertyTreeBuilder::updateEffect(
     const LayoutObject& object,
     PaintPropertyTreeBuilderContext& context) {
@@ -424,14 +456,19 @@ void PaintPropertyTreeBuilder::updateEffect(
       object.isBoxModelObject() && style.isStackingContext();
   if (!isCSSIsolatedGroup && !object.isSVGChild()) {
     if (object.needsPaintPropertyUpdate() || context.forceSubtreeUpdate) {
-      if (auto* properties = object.getMutableForPainting().paintProperties())
+      if (auto* properties = object.getMutableForPainting().paintProperties())
{
         context.forceSubtreeUpdate |= properties->clearEffect();
+        context.forceSubtreeUpdate |= properties->clearMask();
+        context.forceSubtreeUpdate |= properties->clearMaskClip();
+      }
     }
     return;
   }
 
   // TODO(trchen): Can't omit effect node if we have 3D children.
   if (object.needsPaintPropertyUpdate() || context.forceSubtreeUpdate) {
+    const ClipPaintPropertyNode* outputClip = context.inputClipOfCurrentEffect;
+
     bool effectNodeNeeded = false;
 
     // Can't omit effect node if we have paint children with exotic blending.
@@ -457,6 +494,85 @@ void PaintPropertyTreeBuilder::updateEffect(
     if (opacity != 1.0f)
       effectNodeNeeded = true;
 
+    // We may begin to composite our subtree prior to an animation starts,
+    // but a compositor element ID is only needed when an animation is current.
+    CompositorElementId compositorElementId =
+        style.hasCurrentOpacityAnimation()
+            ? createDomNodeBasedCompositorElementId(object)
+            : CompositorElementId();
+    CompositingReasons compositingReasons = CompositingReasonNone;
+    if (CompositingReasonFinder::requiresCompositingForOpacityAnimation(
+            style)) {
+      compositingReasons = CompositingReasonActiveAnimation;
+      effectNodeNeeded = true;
+    }
+    DCHECK(!style.hasCurrentOpacityAnimation() ||
+           compositingReasons != CompositingReasonNone);
+
+    IntRect maskClip;
+    bool hasMask =
+        computeMaskParameters(maskClip, object, context.current.paintOffset);
+    if (hasMask) {
+      effectNodeNeeded = true;
+
+      auto& properties =
object.getMutableForPainting().ensurePaintProperties();
+      context.forceSubtreeUpdate |= properties.updateMaskClip(
+          context.current.clip, context.current.transform,
+          FloatRoundedRect(maskClip));
+      outputClip = properties.maskClip();
+
+      // TODO(crbug.com/683425): PaintArtifactCompositor does not handle
+      // grouping (i.e. descendant-dependent compositing reason) properly yet.
+      // This forces masked subtree always create a layer for now.
+      compositingReasons |= CompositingReasonIsolateCompositedDescendants;
+    } else {
+      if (auto* properties = object.getMutableForPainting().paintProperties())
+        context.forceSubtreeUpdate |= properties->clearMaskClip();
+    }
+
+    if (effectNodeNeeded) {
+      auto& properties =
object.getMutableForPainting().ensurePaintProperties();
+      context.forceSubtreeUpdate |= properties.updateEffect(
+          context.currentEffect, context.current.transform, outputClip,
+          CompositorFilterOperations(), opacity, blendMode, compositingReasons,
+          compositorElementId);
+      if (hasMask) {
+        // TODO(crbug.com/683425): PaintArtifactCompositor does not handle
+        // grouping (i.e. descendant-dependent compositing reason) properly
yet.
+        // Adding CompositingReasonSquashingDisallowed forces mask not getting
+        // squashed into a child effect. Have no compositing reason otherwise.
+        context.forceSubtreeUpdate |= properties.updateMask(
+            properties.effect(), context.current.transform, outputClip,
+            CompositorFilterOperations(), 1.f, SkBlendMode::kDstIn,
+            CompositingReasonSquashingDisallowed, CompositorElementId());
+      } else {
+        context.forceSubtreeUpdate |= properties.clearMask();
+      }
+    } else {
+      if (auto* properties = object.getMutableForPainting().paintProperties())
{
+        context.forceSubtreeUpdate |= properties->clearEffect();
+        context.forceSubtreeUpdate |= properties->clearMask();
+      }
+    }
+  }
+
+  const auto* properties = object.paintProperties();
+  if (properties && properties->effect()) {
+    context.currentEffect = properties->effect();
+    if (properties->maskClip()) {
+      context.inputClipOfCurrentEffect = context.current.clip =
+          context.absolutePosition.clip = context.fixedPosition.clip =
+              properties->maskClip();
+    }
+  }
+}
+
+void PaintPropertyTreeBuilder::updateFilter(
+    const LayoutObject& object,
+    PaintPropertyTreeBuilderContext& context) {
+  const ComputedStyle& style = object.styleRef();
+
+  if (object.needsPaintPropertyUpdate() || context.forceSubtreeUpdate) {
     CompositorFilterOperations filter;
     if (object.isSVGChild()) {
       // TODO(trchen): SVG caches filters in SVGResources. Implement it.
@@ -465,7 +581,6 @@ void PaintPropertyTreeBuilder::updateEffect(
       filter = layer->createCompositorFilterOperationsForFilter(style);
     }
 
-    const ClipPaintPropertyNode* outputClip = context.inputClipOfCurrentEffect;
     // The CSS filter spec didn't specify how filters interact with overflow
     // clips. The implementation here mimics the old Blink/WebKit behavior for
     // backward compatibility.
@@ -484,51 +599,44 @@ void PaintPropertyTreeBuilder::updateEffect(
     // On the other hand, "B" should not be clipped because the overflow clip
is
     // not in its containing block chain, but as the filter output will be
     // clipped, so a blurred "B" may still be invisible.
-    if (!filter.isEmpty()) {
-      effectNodeNeeded = true;
-      outputClip = context.current.clip;
+    const ClipPaintPropertyNode* outputClip = context.current.clip;
 
-      // TODO(trchen): A filter may contain spatial operations such that an
-      // output pixel may depend on an input pixel outside of the output clip.
-      // We should generate a special clip node to represent this expansion.
-    }
-
-    CompositingReasons compositingReasons = CompositingReasonNone;
-    if (CompositingReasonFinder::requiresCompositingForEffectAnimation(style))
{
-      compositingReasons = CompositingReasonActiveAnimation;
-      effectNodeNeeded = true;
-    }
+    // TODO(trchen): A filter may contain spatial operations such that an
+    // output pixel may depend on an input pixel outside of the output clip.
+    // We should generate a special clip node to represent this expansion.
 
+    // We may begin to composite our subtree prior to an animation starts,
+    // but a compositor element ID is only needed when an animation is current.
     CompositorElementId compositorElementId =
-        (style.hasCurrentOpacityAnimation() ||
-         style.hasCurrentFilterAnimation() ||
-         style.hasCurrentBackdropFilterAnimation())
+        style.hasCurrentFilterAnimation()
             ? createDomNodeBasedCompositorElementId(object)
             : CompositorElementId();
-
-    if (effectNodeNeeded) {
+    CompositingReasons compositingReasons =
+        CompositingReasonFinder::requiresCompositingForFilterAnimation(style)
+            ? CompositingReasonActiveAnimation
+            : CompositingReasonNone;
+    DCHECK(!style.hasCurrentFilterAnimation() ||
+           compositingReasons != CompositingReasonNone);
+
+    if (compositingReasons == CompositingReasonNone && filter.isEmpty()) {
+      if (auto* properties = object.getMutableForPainting().paintProperties())
+        context.forceSubtreeUpdate |= properties->clearFilter();
+    } else {
       auto& properties = object.getMutableForPainting().ensurePaintProperti…
(message too large)

trchen

The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the ...

3 years, 10 months ago (2017-02-16 22:53:52 UTC) #37

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/140001

3 years, 10 months ago (2017-02-16 22:55:07 UTC) #38

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-17 03:28:04 UTC) #39

commit-bot: I haz the power

Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/392377)

3 years, 10 months ago (2017-02-17 03:28:06 UTC) #40

trchen

The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the ...

3 years, 10 months ago (2017-02-17 04:35:57 UTC) #42

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173008/160001

3 years, 10 months ago (2017-02-17 04:37:11 UTC) #43

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487306156921020, "parent_rev": "2457ae9482f7e385d88cad62e066ee9203159d46", "commit_rev": "24ffc96f66c428a9820e839af5c47887ce2042b7"}

3 years, 10 months ago (2017-02-17 07:35:51 UTC) #44

commit-bot: I haz the power

Description was changed from ========== [SPv2] Add CSS mask support This CL adds CSS mask ...

3 years, 10 months ago (2017-02-17 07:36:37 UTC) #45

Message was sent while issue was closed.

Description was changed from

==========
[SPv2] Add CSS mask support

This CL adds CSS mask support for SPv2. The following changes have been made:

* Presence of a mask will ensure the main effect node, although the mask
  is not applied to it directly.

* The mask itself will paint into a child isolated group of the main effect
  node, with kDstIn blend mode.

* CSS filter has been moved to a dedicated effect node. This is because the
  mask must composite on top of filtered contents but before applying other
  effects.

* Mask will also create an accompanied output clip, because masked contents
  outside of the mask's extent shall be considered masked out.

* Currently both the main effect nodes and the mask will have forced
  compositing reason, which diverges from SPv1 behavior. This is due to the
  PaintArtifactCompositor doesn't handle grouping correctly yet.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPv2] Add CSS mask support

This CL adds CSS mask support for SPv2. The following changes have been made:

* Presence of a mask will ensure the main effect node, although the mask
  is not applied to it directly.

* The mask itself will paint into a child isolated group of the main effect
  node, with kDstIn blend mode.

* CSS filter has been moved to a dedicated effect node. This is because the
  mask must composite on top of filtered contents but before applying other
  effects.

* Mask will also create an accompanied output clip, because masked contents
  outside of the mask's extent shall be considered masked out.

* Currently both the main effect nodes and the mask will have forced
  compositing reason, which diverges from SPv1 behavior. This is due to the
  PaintArtifactCompositor doesn't handle grouping correctly yet.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2641173008
Cr-Commit-Position: refs/heads/master@{#451263}
Committed:
https://chromium.googlesource.com/chromium/src/+/24ffc96f66c428a9820e839af5c4...
==========

commit-bot: I haz the power

3 years, 10 months ago (2017-02-17 07:36:39 UTC) #46

Message was sent while issue was closed.

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/24ffc96f66c428a9820e839af5c4...

Issue 2641173008: [SPv2] Add CSS mask support (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix transform space application, split filter from effect node, rename hasCompositedMask, temporari… #

Patch Set 3 : fix missed effect --> filter replacement for outputClip #

Patch Set 4 : update layout test expectation && add unit tests #

Patch Set 5 : update comments, add Ahem support to RenderingTests #

Patch Set 6 : rebase & fix windows build issue #

Patch Set 7 : test data path issue? #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Messages