[SPv2] Add CSS mask support

third_party/WebKit/Source/core/paint/PaintLayer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
  * reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
@@ skipping 2633 matching lines @@
   }
   if (m_rareData || groupedMapping)
     ensureRareData().groupedMapping = groupedMapping;
 #if DCHECK_IS_ON()
   DCHECK(!groupedMapping || groupedMapping->verifyLayerInSquashingVector(this));
 #endif
   if (options == InvalidateLayerAndRemoveFromMapping && groupedMapping)
     groupedMapping->setNeedsGraphicsLayerUpdate(GraphicsLayerUpdateSubtree);
 }
 
-bool PaintLayer::hasCompositedMask() const {
+bool PaintLayer::maskBlendingAppliedByCompositor() const {

[chrishtr, 2017/02/11 23:55:11]

In SPv2 mode, it's not really "applied by compositor", but
insted applied by the property node, which may or may not
end up surviving squashing in PaintArtifactCompositor.
Maybe just add a TODO to rename this after launching?

[trchen, 2017/02/13 21:12:02]

The property tree is the representation of the effect and will be ultimately
applied by PaintArtifactCompositor/cc. IMO it isn't confusing if we consider PAC
a part of the compositor?

Anyway, I don't even think this should be a PaintLayer method. This information
really belongs to paintInfo.flags. We shouldn't lose sleep over its naming. :D

[chrishtr, 2017/02/13 23:23:49]

ok

+  DCHECK(m_layoutObject->hasMask());
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    return true;
   return m_rareData && m_rareData->compositedLayerMapping &&
          m_rareData->compositedLayerMapping->hasMaskLayer();
 }
 
 bool PaintLayer::hasCompositedClippingMask() const {
   return m_rareData && m_rareData->compositedLayerMapping &&
          m_rareData->compositedLayerMapping->hasChildClippingMaskLayer();
 }
 
 bool PaintLayer::paintsWithTransform(GlobalPaintFlags globalPaintFlags) const {
@@ skipping 526 matching lines @@
 }
 
 void showLayerTree(const blink::LayoutObject* layoutObject) {
   if (!layoutObject) {
     LOG(INFO) << "Cannot showLayerTree. Root is (nil)";
     return;
   }
   showLayerTree(layoutObject->enclosingLayer());
 }
 #endif