Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2641173008: [SPv2] Add CSS mask support (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
index e6b4a2d2fbccebabffc1f04741613a76f531e207..8e12a8a4cff4cb64ef531c9bf70c6e96e2c131c1 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
@@ -178,17 +178,32 @@ bool CompositingReasonFinder::requiresCompositingForAnimation(
return style.shouldCompositeForCurrentAnimations();
}
-bool CompositingReasonFinder::requiresCompositingForEffectAnimation(
+bool CompositingReasonFinder::requiresCompositingForOpacityAnimation(
const ComputedStyle& style) {
- if (style.subtreeWillChangeContents()) {
- return style.isRunningOpacityAnimationOnCompositor() ||
- style.isRunningFilterAnimationOnCompositor() ||
- style.isRunningBackdropFilterAnimationOnCompositor();
- }
+ return style.subtreeWillChangeContents()
+ ? style.isRunningOpacityAnimationOnCompositor()
+ : style.hasCurrentOpacityAnimation();
+}
+
+bool CompositingReasonFinder::requiresCompositingForFilterAnimation(
+ const ComputedStyle& style) {
+ return style.subtreeWillChangeContents()
+ ? style.isRunningFilterAnimationOnCompositor()
+ : style.hasCurrentFilterAnimation();
+}
- return style.hasCurrentOpacityAnimation() ||
- style.hasCurrentFilterAnimation() ||
- style.hasCurrentBackdropFilterAnimation();
+bool CompositingReasonFinder::requiresCompositingForBackdropFilterAnimation(
+ const ComputedStyle& style) {
+ return style.subtreeWillChangeContents()
+ ? style.isRunningBackdropFilterAnimationOnCompositor()
+ : style.hasCurrentBackdropFilterAnimation();
+}
+
+bool CompositingReasonFinder::requiresCompositingForEffectAnimation(
+ const ComputedStyle& style) {
+ return requiresCompositingForOpacityAnimation(style) ||
+ requiresCompositingForFilterAnimation(style) ||
+ requiresCompositingForBackdropFilterAnimation(style);
}
bool CompositingReasonFinder::requiresCompositingForTransformAnimation(

Powered by Google App Engine
This is Rietveld 408576698