Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2640923004: CrOS WebUI: Show 'Connecting' in network list and blur selected item (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS WebUI: Show 'Connecting' in network list and blur selected item This also fixes the connected and connecting text to match the status area UI. BUG=681982 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2640923004 Cr-Commit-Position: refs/heads/master@{#445078} Committed: https://chromium.googlesource.com/chromium/src/+/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.js View 1 2 3 chunks +24 lines, -10 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.js View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_onc_types.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
3 years, 11 months ago (2017-01-20 00:01:10 UTC) #4
Alexander Alekseev
lgtm
3 years, 11 months ago (2017-01-20 00:51:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640923004/40001
3 years, 11 months ago (2017-01-20 16:06:09 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 16:55:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53571e573b51a31cc1ad5c1aeda7...

Powered by Google App Engine
This is Rietveld 408576698