Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ui/webui/resources/cr_elements/network/cr_network_list_item.js

Issue 2640923004: CrOS WebUI: Show 'Connecting' in network list and blur selected item (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/network/cr_network_list_item.js
diff --git a/ui/webui/resources/cr_elements/network/cr_network_list_item.js b/ui/webui/resources/cr_elements/network/cr_network_list_item.js
index a54ddf3c3f223e7daedbbc7a52b2b1d35d7ba9dc..8d3841daa869ec6bf4ba3ff664d2aa7101a8b8a4 100644
--- a/ui/webui/resources/cr_elements/network/cr_network_list_item.js
+++ b/ui/webui/resources/cr_elements/network/cr_network_list_item.js
@@ -79,6 +79,7 @@ Polymer({
/**
* This gets called for network items and custom items.
+ * @return {string}
* @private
*/
getItemName_: function() {
@@ -95,33 +96,44 @@ Polymer({
return CrOncStrings['OncType' + network.Type];
},
- /** @private */
+ /**
+ * @return {boolean}
+ * @private
+ */
isStateTextVisible_: function() {
- return !!this.networkState && (!this.isListItem || this.isConnected_());
+ return !!this.networkState &&
+ (!this.isListItem || (this.networkState.ConnectionState !=
+ CrOnc.ConnectionState.NOT_CONNECTED));
},
- /** @private */
+ /**
+ * @return {boolean}
+ * @private
+ */
isStateTextConnected_: function() {
return this.isListItem && this.isConnected_();
},
/**
* This only gets called for network items once networkState is set.
+ * @return {string}
* @private
*/
getNetworkStateText_: function() {
if (!this.isStateTextVisible_())
return '';
- let network = this.networkState;
+ var network = this.networkState;
+ var state = network.ConnectionState;
+ var name = CrOnc.getNetworkName(network);
if (this.isListItem) {
- if (this.isConnected_())
+ if (state == CrOnc.ConnectionState.CONNECTED)
return CrOncStrings.networkListItemConnected;
+ if (state == CrOnc.ConnectionState.CONNECTING)
+ return CrOncStrings.networkListItemConnecting;
return '';
}
- if (network.Name && network.ConnectionState) {
- return this.getConnectionStateText_(
- network.ConnectionState, CrOnc.getNetworkName(network));
- }
+ if (name && state)
+ return this.getConnectionStateText_(state, name);
return CrOncStrings.networkDisabled;
},
@@ -137,7 +149,9 @@ Polymer({
case CrOnc.ConnectionState.CONNECTED:
return name;
case CrOnc.ConnectionState.CONNECTING:
- return CrOncStrings.networkListItemConnecting.replace('$1', name);
+ if (name)
+ return CrOncStrings.networkListItemConnectingTo.replace('$1', name);
+ return CrOncStrings.networkListItemConnecting;
case CrOnc.ConnectionState.NOT_CONNECTED:
return CrOncStrings.networkListItemNotConnected;
}

Powered by Google App Engine
This is Rietveld 408576698