Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2640743003: [turbofan] Properly assign types to Array/String iterators. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly assign types to Array/String iterators. When inlining allocations for Array and String iterators, make sure the allocations have proper types on it (rather than just Type::Any). This allows us to escape analyze the iterators in a couple of more cases, i.e. in this very simple case: function f(a) { const it = a[Symbol.iterator](); return it.next().value; } R=jarin@chromium.org BUG=v8:4586, v8:5448 Review-Url: https://codereview.chromium.org/2640743003 Cr-Commit-Position: refs/heads/master@{#42449} Committed: https://chromium.googlesource.com/v8/v8/+/977038516bbdd0427eacf8be4496e63b451f3ffe

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/js-builtin-reducer.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-18 10:05:14 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the escaping iterator in the trivial case. Please take ...
3 years, 11 months ago (2017-01-18 10:14:10 UTC) #4
Benedikt Meurer
Hey Jaro, Here's the fix for the escaping iterator in the trivial case. Please take ...
3 years, 11 months ago (2017-01-18 10:14:10 UTC) #5
Jarin
lgtm
3 years, 11 months ago (2017-01-18 10:48:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640743003/20001
3 years, 11 months ago (2017-01-18 11:22:24 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 11:24:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/977038516bbdd0427eacf8be4496e63b451...

Powered by Google App Engine
This is Rietveld 408576698