Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 2646433002: [deoptimizer] Materialize array iterators in the deoptimizer. (Closed)

Created:
3 years, 11 months ago by Jarin
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Materialize array iterators in the deoptimizer. This also introduces exhaustive switch-cases for instance types. BUG=chromium:681383 Review-Url: https://codereview.chromium.org/2646433002 Cr-Commit-Position: refs/heads/master@{#42447} Committed: https://chromium.googlesource.com/v8/v8/+/9091eb19be52d695616dc76ad87c0217f7b5b2a0

Patch Set 1 #

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -194 lines) Patch
M src/deoptimizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 6 chunks +327 lines, -194 lines 0 comments Download
A test/mjsunit/regress/regress-681383.js View 1 chunk +19 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
Jarin
Could you take a look, please?
3 years, 11 months ago (2017-01-18 09:53:29 UTC) #2
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-18 09:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646433002/20001
3 years, 11 months ago (2017-01-18 10:29:24 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 10:55:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9091eb19be52d695616dc76ad87c0217f7b...

Powered by Google App Engine
This is Rietveld 408576698