Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2641843002: [turbofan] Lower JSLoadMessage/JSStoreMessage earlier. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower JSLoadMessage/JSStoreMessage earlier. Lower JSLoadMessage and JSStoreMessage in JSTypedLowering to allow for optimizations across try-catch, try-finally, for-of, destructuring, etc. BUG=v8:5448 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2641843002 Cr-Commit-Position: refs/heads/master@{#42453} Committed: https://chromium.googlesource.com/v8/v8/+/2af52484cd8e16b1571b1ed760d2d043cf0169b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -34 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +26 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-18 11:42:31 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-18 11:45:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641843002/1
3 years, 11 months ago (2017-01-18 11:47:23 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 12:09:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2af52484cd8e16b1571b1ed760d2d043cf0...

Powered by Google App Engine
This is Rietveld 408576698