Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2639583002: [runtime] Remove redundant StoreMode enum. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove redundant StoreMode enum. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2639583002 Cr-Commit-Position: refs/heads/master@{#42419} Committed: https://chromium.googlesource.com/v8/v8/+/23fb6cf07da51a446fc6d90876d4ec3519862460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -35 lines) Patch
M src/map-updater.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/objects.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/objects.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-17 14:10:20 UTC) #2
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-17 15:37:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639583002/40001
3 years, 11 months ago (2017-01-17 15:39:49 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:41:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/23fb6cf07da51a446fc6d90876d4ec35198...

Powered by Google App Engine
This is Rietveld 408576698