[runtime] Add PropertyConstness bit to PropertyDetails.

[runtime] Add PropertyConstness bit to PropertyDetails.

Currently PropertyConstness is still in sync with PropertyLocation.

BUG=v8:5495
Review-Url: https://codereview.chromium.org/2591233002
Cr-Commit-Position: refs/heads/master@{#42497}
Committed: https://chromium.googlesource.com/v8/v8/+/1dcd8b23820c427903637b040482358640ec33fd

[Igor Sheludko, 2016-12-24 00:12:16]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-01-16 18:58:38]

Description was changed from

==========
[runtime] Introduce constaness bit.

BUG=v8:5495
==========

to

==========
[runtime] Introduce constness bit.

BUG=v8:5495
==========

[Igor Sheludko, 2017-01-16 18:58:47]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2017-01-17 10:47:43]

Patchset #2 (id:60001) has been deleted

[Igor Sheludko, 2017-01-17 10:47:46]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2017-01-17 11:33:44]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2017-01-17 11:33:55]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 11:33:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-17 11:35:27]

Description was changed from

==========
[runtime] Introduce constness bit.

BUG=v8:5495
==========

to

==========
[runtime] Add PropertyConstness bit to PropertyDetails.

Currently PropertyConstness is still in sync with PropertyLocation.

BUG=v8:5495
==========

[commit-bot: I haz the power, 2017-01-17 12:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 12:02:51]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-17 13:06:57]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2017-01-17 13:06:58]

PTAL

[Igor Sheludko, 2017-01-17 13:44:48]

Patchset #1 (id:100001) has been deleted

[Igor Sheludko, 2017-01-17 14:15:32]

Patchset #1 (id:120001) has been deleted

[Igor Sheludko, 2017-01-17 14:15:39]

Patchset #1 (id:140001) has been deleted

[Igor Sheludko, 2017-01-17 15:01:42]

Patchset #1 (id:160001) has been deleted

[Toon Verwaest, 2017-01-18 12:04:05]

https://codereview.chromium.org/2591233002/diff/180001/src/map-updater.cc
File src/map-updater.cc (right):

https://codereview.chromium.org/2591233002/diff/180001/src/map-updater.cc#new...
src/map-updater.cc:431: if (next_location == kField) next_constness = kMutable;
The description doesn't describe the line above, but the line below?
I guess the line above is temporary since we don't yet support in-field
constants? In that case please mark it as such.

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h
File src/property-details.h (right):

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h...
src/property-details.h:390: inline bool LocationFitsInto(PropertyLocation what,
PropertyLocation where) {
Maybe LocationIsMoreGeneralThan? That fits the Generalize function below.

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h...
src/property-details.h:391: return where == kField || what == kDescriptor;
// Everything fits in a field, and a descriptor only fits into a descriptor.

[Igor Sheludko, 2017-01-18 14:05:57]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 14:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-18 14:06:43]

https://codereview.chromium.org/2591233002/diff/180001/src/map-updater.cc
File src/map-updater.cc (right):

https://codereview.chromium.org/2591233002/diff/180001/src/map-updater.cc#new...
src/map-updater.cc:431: if (next_location == kField) next_constness = kMutable;
On 2017/01/18 12:04:05, Toon Verwaest wrote:
> The description doesn't describe the line above, but the line below?
> I guess the line above is temporary since we don't yet support in-field
> constants? In that case please mark it as such.

Done.

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h
File src/property-details.h (right):

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h...
src/property-details.h:390: inline bool LocationFitsInto(PropertyLocation what,
PropertyLocation where) {
On 2017/01/18 12:04:05, Toon Verwaest wrote:
> Maybe LocationIsMoreGeneralThan? That fits the Generalize function below.

Done.

https://codereview.chromium.org/2591233002/diff/180001/src/property-details.h...
src/property-details.h:391: return where == kField || what == kDescriptor;
On 2017/01/18 12:04:05, Toon Verwaest wrote:
> // Everything fits in a field, and a descriptor only fits into a descriptor.

Done.

[commit-bot: I haz the power, 2017-01-18 14:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:42:23]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-18 14:52:03]

Patchset #2 (id:190001) has been deleted

[Igor Sheludko, 2017-01-18 15:12:40]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 15:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 15:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 15:47:16]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2017-01-19 11:33:54]

lgtm

[Igor Sheludko, 2017-01-19 11:42:31]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 12:02:08]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1484826151337480,
"parent_rev": "a8f289075758bdce5296ef517a269e1596b0ab99", "commit_rev":
"1dcd8b23820c427903637b040482358640ec33fd"}

[commit-bot: I haz the power, 2017-01-19 12:02:13]

Description was changed from

==========
[runtime] Add PropertyConstness bit to PropertyDetails.

Currently PropertyConstness is still in sync with PropertyLocation.

BUG=v8:5495
==========

to

==========
[runtime] Add PropertyConstness bit to PropertyDetails.

Currently PropertyConstness is still in sync with PropertyLocation.

BUG=v8:5495

Review-Url: https://codereview.chromium.org/2591233002
Cr-Commit-Position: refs/heads/master@{#42497}
Committed:
https://chromium.googlesource.com/v8/v8/+/1dcd8b23820c427903637b040482358640e...
==========

[commit-bot: I haz the power, 2017-01-19 12:02:14]

Committed patchset #2 (id:210001) as
https://chromium.googlesource.com/v8/v8/+/1dcd8b23820c427903637b040482358640e...