Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2632373002: [runtime] Add DescriptorArray::GeneralizeAllFields(). (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add DescriptorArray::GeneralizeAllFields(). ... and rename [Copy]GeneralizeAllRepresentations() -> [Copy]GeneralizeAllFields(). BUG=v8:5495 Review-Url: https://codereview.chromium.org/2632373002 Cr-Commit-Position: refs/heads/master@{#42418} Committed: https://chromium.googlesource.com/v8/v8/+/322a37856a786723cf995bb005f66b9f1573e6ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -57 lines) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/map-updater.h View 1 chunk +1 line, -1 line 0 comments Download
M src/map-updater.cc View 8 chunks +11 lines, -12 lines 0 comments Download
M src/objects.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/objects.cc View 4 chunks +26 lines, -26 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (22 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-17 13:19:05 UTC) #9
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-17 15:05:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632373002/120001
3 years, 11 months ago (2017-01-17 15:37:10 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:39:11 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/322a37856a786723cf995bb005f66b9f157...

Powered by Google App Engine
This is Rietveld 408576698