Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2639423003: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed undefined type in Network Waterfall for Other types This patch fixes issue where the network waterfall cannot resolve the type color of Other if the mime-type is not in the list of known types. (ie: when it resolves to default type "other") R=dgozman BUG=678392 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2609863005 Cr-Commit-Position: refs/heads/master@{#442459} (cherry picked from commit aae7548bfd243de6452e770e42884ead54093485) Review-Url: https://codereview.chromium.org/2639423003 Cr-Commit-Position: refs/branch-heads/2924@{#800} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/ac8ad65bd29924d18cf5d015e686c11403704b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
allada
PTL
3 years, 11 months ago (2017-01-19 01:18:40 UTC) #3
kozy
lgtm
3 years, 11 months ago (2017-01-19 01:18:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639423003/1
3 years, 11 months ago (2017-01-19 01:20:09 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 01:26:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac8ad65bd29924d18cf5d015e686...

Powered by Google App Engine
This is Rietveld 408576698