Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2639423003: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index 382e9e00ce7d8fc37fb0e4d5eaf091003918d371..65d7a81ca966ab09f01bb68ad72b724ccd09ab17 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -359,7 +359,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
if (this._borderColorsForResourceTypeCache.has(resourceType))
return this._borderColorsForResourceTypeCache.get(resourceType);
var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourceType;
- var color = colorsForResourceType[resourceType] || colorsForResourceType.Other;
+ var color = colorsForResourceType[resourceType] || colorsForResourceType.other;
var parsedColor = Common.Color.parse(color);
var hsla = parsedColor.hsla();
hsla[1] /= 2;
@@ -377,7 +377,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
_colorForResourceType(context, request) {
var colorsForResourceType = Network.NetworkWaterfallColumn._colorsForResourceType;
var resourceType = request.resourceType();
- var color = colorsForResourceType[resourceType] || colorsForResourceType.Other;
+ var color = colorsForResourceType[resourceType] || colorsForResourceType.other;
if (request.cached())
return color;
@@ -610,6 +610,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
*/
Network.NetworkWaterfallColumn.RequestData;
+/** @enum {string} */
Network.NetworkWaterfallColumn._colorsForResourceType = {
document: 'hsl(215, 100%, 80%)',
font: 'hsl(8, 100%, 80%)',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698