Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2609863005: [Devtools] Fixed undefined type in Network Waterfall for Other types (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed undefined type in Network Waterfall for Other types This patch fixes issue where the network waterfall cannot resolve the type color of Other if the mime-type is not in the list of known types. (ie: when it resolves to default type "other") R=dgozman BUG=678392 Review-Url: https://codereview.chromium.org/2609863005 Cr-Commit-Position: refs/heads/master@{#442459} Committed: https://chromium.googlesource.com/chromium/src/+/aae7548bfd243de6452e770e42884ead54093485

Patch Set 1 #

Total comments: 1

Patch Set 2 : [Devtools] Fixed undefined type in Network Waterfall for Other types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
allada
PTL
3 years, 11 months ago (2017-01-04 22:30:39 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2609863005/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2609863005/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode840 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:840: var groupKey = request.connectionId; Unrelated?
3 years, 11 months ago (2017-01-09 23:59:51 UTC) #3
allada
done.
3 years, 11 months ago (2017-01-10 00:14:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609863005/20001
3 years, 11 months ago (2017-01-10 00:15:21 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 03:04:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aae7548bfd243de6452e770e4288...

Powered by Google App Engine
This is Rietveld 408576698