components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc - Issue 2639393002: [Sync] Make SMTP always have the dump stack function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

Issue 2639393002: [Sync] Make SMTP always have the dump stack function. (Closed)

Patch Set: Rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/two_client_uss_sync_test.cc ('k') | components/browser_sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

index 12702868ce18b6f1d878ccbdccc6db9bb03d10ec..c2d71f4fd0862f69009f6f8337353819e62fab30 100644

--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

@@ -11,6 +11,7 @@

#include <vector>

#include "base/bind.h"

+#include "base/debug/dump_without_crashing.h"

#include "base/memory/ptr_util.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/browser/proto/autofill_sync.pb.h"

@@ -25,6 +26,7 @@

using base::Optional;

using base::Time;

+using base::debug::DumpWithoutCrashing;

using sync_pb::AutofillSpecifics;

using syncer::EntityChange;

using syncer::EntityChangeList;

@@ -274,7 +276,10 @@ void AutocompleteSyncBridge::CreateForWebDataServiceAndBackend(

web_data_service->GetDBUserData()->SetUserData(

UserDataKey(),

new AutocompleteSyncBridge(

- web_data_backend, base::Bind(&ModelTypeChangeProcessor::Create)));

+ web_data_backend,

+ base::BindRepeating(

+ &ModelTypeChangeProcessor::Create,

+ base::BindRepeating(base::IgnoreResult(&DumpWithoutCrashing)))));

skym 2017/01/19 17:58:36 Can you plumb channel through to here and filter o

maxbogue 2017/01/20 20:39:47 Whoops, I never responded to this. I've prepared a

}

// static