Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2639393002: [Sync] Make SMTP always have the dump stack function. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index 806d21ce4aecb29711621dfffd00f0d8008aa16c..ba1f82b5675231513528fe11b038271acc55c9f1 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -6,7 +6,6 @@
#include <utility>
-#include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
@@ -142,10 +141,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
// Use an error callback that always uploads a stacktrace if it can to help
// get USS as stable as possible.
sync_service->RegisterDataTypeController(
- base::MakeUnique<ModelTypeController>(
- syncer::DEVICE_INFO,
- base::Bind(base::IgnoreResult(&base::debug::DumpWithoutCrashing)),
- sync_client_, ui_thread_));
+ base::MakeUnique<ModelTypeController>(syncer::DEVICE_INFO, sync_client_,
+ ui_thread_));
} else {
sync_service->RegisterDataTypeController(
base::MakeUnique<DeviceInfoDataTypeController>(
@@ -158,10 +155,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
if (!disabled_types.Has(syncer::AUTOFILL)) {
if (base::FeatureList::IsEnabled(switches::kSyncUSSAutocomplete)) {
sync_service->RegisterDataTypeController(
- base::MakeUnique<ModelTypeController>(
- syncer::AUTOFILL,
- base::Bind(base::IgnoreResult(&base::debug::DumpWithoutCrashing)),
- sync_client_, db_thread_));
+ base::MakeUnique<ModelTypeController>(syncer::AUTOFILL, sync_client_,
+ db_thread_));
} else {
sync_service->RegisterDataTypeController(
base::MakeUnique<AutofillDataTypeController>(
@@ -268,8 +263,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
syncer::GROUP_UI, ui_thread_));
} else {
sync_service->RegisterDataTypeController(
- base::MakeUnique<ModelTypeController>(
- syncer::PREFERENCES, error_callback, sync_client_, ui_thread_));
+ base::MakeUnique<ModelTypeController>(syncer::PREFERENCES,
+ sync_client_, ui_thread_));
}
}
@@ -293,8 +288,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
if (!disabled_types.Has(syncer::READING_LIST) &&
reading_list::switches::IsReadingListEnabled()) {
sync_service->RegisterDataTypeController(
- base::MakeUnique<ModelTypeController>(
- syncer::READING_LIST, error_callback, sync_client_, ui_thread_));
+ base::MakeUnique<ModelTypeController>(syncer::READING_LIST,
+ sync_client_, ui_thread_));
}
}

Powered by Google App Engine
This is Rietveld 408576698