Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2639283005: Add NOEXPORT=true commit message whenever import script is run. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, foolip
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NOEXPORT=true commit message whenever import script is run. BUG=682340 Review-Url: https://codereview.chromium.org/2639283005 Cr-Commit-Position: refs/heads/master@{#445223} Committed: https://chromium.googlesource.com/chromium/src/+/acf567697de4b29d5c60c4d14b72ab1f51af95b3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test for NOEXPORT tag movement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
3 years, 11 months ago (2017-01-20 00:15:41 UTC) #2
jeffcarp
https://codereview.chromium.org/2639283005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2639283005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode363 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:363: description = description.replace('NOEXPORT=true', '') Can you add a unit ...
3 years, 11 months ago (2017-01-20 22:12:52 UTC) #7
qyearsley
https://codereview.chromium.org/2639283005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2639283005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode363 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:363: description = description.replace('NOEXPORT=true', '') On 2017/01/20 at 22:12:52, jeffcarp ...
3 years, 11 months ago (2017-01-20 22:32:44 UTC) #8
jeffcarp
lgtm
3 years, 11 months ago (2017-01-20 23:00:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639283005/20001
3 years, 11 months ago (2017-01-20 23:03:20 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:19:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acf567697de4b29d5c60c4d14b72...

Powered by Google App Engine
This is Rietveld 408576698