third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py - Issue 2639283005: Add NOEXPORT=true commit message whenever import script is run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2639283005: Add NOEXPORT=true commit message whenever import script is run. (Closed)

Patch Set: Add test for NOEXPORT tag movement Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

index c17d189ac7876058294e89e786b2e47338e3133e..28b18d3b048ba96ddb132fd9d8343e1c454873d7 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

@@ -227,7 +227,9 @@ class DepsUpdater(object):

return return_code == 1

def _commit_message(self, chromium_commit, import_commit):

- return ('Import %s\n\nUsing update-w3c-deps in Chromium %s.\n\n' %

+ return ('Import %s\n\n'

+ 'Using update-w3c-deps in Chromium %s.\n\n'

+ 'NOEXPORT=true' %

(import_commit, chromium_commit))

@staticmethod

@@ -338,6 +340,8 @@ class DepsUpdater(object):

if build_link:

description += 'Build: %s\n\n' % build_link

description += 'TBR=qyearsley@chromium.org\n'

+ # Move any NOEXPORT tag to the end of the description.

+ description = description.replace('NOEXPORT=true', '')

description += 'NOEXPORT=true'

return description

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py » ('j') | no next file with comments »