Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Issue 2639283005: Add NOEXPORT=true commit message whenever import script is run. (Closed)
Patch Set: Add test for NOEXPORT tag movement Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
index f5524feb6e7b9a644da99a85084e414c6cd6528d..6df746fe1b9954b3ec3738d27044465353303718 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
@@ -75,7 +75,9 @@ class DepsUpdaterTest(unittest.TestCase):
updater = DepsUpdater(MockHost())
self.assertEqual(
updater._commit_message('aaaa', '1111'),
- 'Import 1111\n\nUsing update-w3c-deps in Chromium aaaa.\n\n')
+ 'Import 1111\n\n'
+ 'Using update-w3c-deps in Chromium aaaa.\n\n'
+ 'NOEXPORT=true')
def test_cl_description_with_empty_environ(self):
host = MockHost()
@@ -105,6 +107,17 @@ class DepsUpdaterTest(unittest.TestCase):
'NOEXPORT=true'))
self.assertEqual(host.executive.calls, [['git', 'log', '-1', '--format=%B']])
+ def test_cl_description_moves_noexport_tag(self):
+ host = MockHost()
+ host.executive = MockExecutive(output='Summary\n\nNOEXPORT=true')
+ updater = DepsUpdater(host)
+ description = updater._cl_description()
+ self.assertEqual(
+ description,
+ ('Summary\n\n'
+ 'TBR=qyearsley@chromium.org\n'
+ 'NOEXPORT=true'))
+
def test_generate_manifest_command_not_found(self):
# If we're updating csswg-test, then the manifest file won't be found.
host = MockHost()
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698