Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

We should traverse into composited inlines even if they are stacking
context, because there might be floating objects which belong to
ancestors in paint order.

During traverse for paint invalidation, when we encounter a floating
object, we should mark the real painting layer for paint invalidation
which may be above the tip of the subtree being traversed.

BUG=644144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2639283003
Cr-Commit-Position: refs/heads/master@{#445679}
Committed: https://chromium.googlesource.com/chromium/src/+/f105471106f4c821364165bdd991ce13196f5496

[Xianzhu, 2017-01-18 22:41:22]

Description was changed from

==========
Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

We should traverse into composited inlines even if they are stacking
context, because there might be floating objects which belong to
ancestors in paint order.

During traverse for paint invalidation, when we encounter a floating
object, we should mark the real painting layer for paint invalidation
which may be above the tip of the subtree being traversed.

BUG=644144
==========

to

==========
Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

We should traverse into composited inlines even if they are stacking
context, because there might be floating objects which belong to
ancestors in paint order.

During traverse for paint invalidation, when we encounter a floating
object, we should mark the real painting layer for paint invalidation
which may be above the tip of the subtree being traversed.

BUG=644144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-01-18 22:41:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 22:42:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-18 22:46:48]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, trchen@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:57:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-01-19 00:18:13]

There are failures in telemetry_perf_unittests. Debugging.

[Xianzhu, 2017-01-19 00:18:25]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 02:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:19:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-01-19 21:01:39]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:02:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-01-19 21:22:27]

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp (right):

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:80: if
(!object.isLayoutBlockFlow() && descendant->isFloating()) {
&& !isStacked() ? See https://codereview.chromium.org/2640053004

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:149: } else if
(object.isFloating() && object.parent() &&
Same here: skip isStacked() objects?

[commit-bot: I haz the power, 2017-01-19 22:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:52:50]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-01-20 07:01:41]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 07:02:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 07:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 07:29:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-01-20 17:29:53]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 17:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-20 17:38:12]

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp (right):

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:80: if
(!object.isLayoutBlockFlow() && descendant->isFloating()) {
On 2017/01/19 21:22:26, chrishtr wrote:
> && !isStacked() ? See https://codereview.chromium.org/2640053004

Yes. Moved the case under the condition at new line 86.

https://codereview.chromium.org/2639283003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:149: } else if
(object.isFloating() && object.parent() &&
On 2017/01/19 21:22:26, chrishtr wrote:
> Same here: skip isStacked() objects?

Now rebased on https://codereview.chromium.org/2642763009/ and use
canContainFloatingObject().

[commit-bot: I haz the power, 2017-01-20 19:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:33:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-21 04:01:04]

lgtm

https://codereview.chromium.org/2639283003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp (right):

https://codereview.chromium.org/2639283003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:72: //
descendants may not belong to |object| but belong to an ancestor. This
Add an example of why non-block-flow elements might have this problem.

[Xianzhu, 2017-01-24 06:38:39]

https://codereview.chromium.org/2639283003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp (right):

https://codereview.chromium.org/2639283003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp:72: //
descendants may not belong to |object| but belong to an ancestor. This
On 2017/01/21 04:01:04, chrishtr wrote:
> Add an example of why non-block-flow elements might have this problem.

Done.

[Xianzhu, 2017-01-24 06:40:13]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-01-24 06:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2639283003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-24 06:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 08:15:38]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485240013169320,
"parent_rev": "f5a497cd5ce83519a9c71bd1ef877f85ec022d38", "commit_rev":
"f105471106f4c821364165bdd991ce13196f5496"}

[commit-bot: I haz the power, 2017-01-24 08:16:14]

Description was changed from

==========
Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

We should traverse into composited inlines even if they are stacking
context, because there might be floating objects which belong to
ancestors in paint order.

During traverse for paint invalidation, when we encounter a floating
object, we should mark the real painting layer for paint invalidation
which may be above the tip of the subtree being traversed.

BUG=644144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases

We should traverse into composited inlines even if they are stacking
context, because there might be floating objects which belong to
ancestors in paint order.

During traverse for paint invalidation, when we encounter a floating
object, we should mark the real painting layer for paint invalidation
which may be above the tip of the subtree being traversed.

BUG=644144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2639283003
Cr-Commit-Position: refs/heads/master@{#445679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f105471106f4c821364165bdd991...
==========

[commit-bot: I haz the power, 2017-01-24 08:16:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f105471106f4c821364165bdd991...